-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a distance constraint to momentum. #212
Open
jeongseok-meta
wants to merge
4
commits into
main
Choose a base branch
from
export-D69750024
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request was exported from Phabricator. Differential Revision: D69750024 |
Summary: Should be mean/std not min/max. Differential Revision: D69750023
Summary: We need this to support camera projections in pymomentum. We'll allow a separate projection matrix per-constraint to support generating a linearized projection for each pixel constraint. Differential Revision: D69750025
Summary: We need to be able to compute the change in gradient wrt the projection to support differentiable IK. Differential Revision: D69750019
This pull request was exported from Phabricator. Differential Revision: D69750024 |
jeongseok-meta
pushed a commit
that referenced
this pull request
Feb 18, 2025
Summary: Pull Request resolved: #212 This is a constraint that measures the distance of a joint from the provided origin and penalizes if that distance is not equal to the desired target distance. This can be used to enforce e.g. distance-from-camera constraints. Reviewed By: jeongseok-meta Differential Revision: D69750024
2c9eab0
to
1986363
Compare
Summary: Pull Request resolved: #212 This is a constraint that measures the distance of a joint from the provided origin and penalizes if that distance is not equal to the desired target distance. This can be used to enforce e.g. distance-from-camera constraints. Reviewed By: jeongseok-meta Differential Revision: D69750024
This pull request was exported from Phabricator. Differential Revision: D69750024 |
1986363
to
61e3712
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This is a constraint that measures the distance of a joint from the provided
origin and penalizes if that distance is not equal to the desired target
distance. This can be used to enforce e.g. distance-from-camera constraints.
Reviewed By: jeongseok-meta
Differential Revision: D69750024