Fix segfault in gfx-replay when there's an invalid path. (#2537)

facebookresearch · Jan 24, 2025 · c97b2ac · c97b2ac
1 parent 1278a08
commit c97b2ac
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/src/esp/gfx/replay/Player.cpp b/src/esp/gfx/replay/Player.cpp
@@ -248,8 +248,13 @@ void Player::applyKeyframe(const Keyframe& keyframe) {
 
   for (const auto& pair : keyframe.metadata) {
     const auto& instanceKey = pair.first;
-    implementation_->setNodeMetadata(createdInstances_[instanceKey],
-                                     pair.second);
+    const auto& it = createdInstances_.find(instanceKey);
+    if (it == createdInstances_.end()) {
+      // Missing instance for this key due to a failed instance creation
+      continue;
+    }
+    auto* node = it->second;
+    implementation_->setNodeMetadata(node, pair.second);
     creationRecords_[instanceKey].metadata = pair.second;
   }