Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--[Bugfix] - Miscellaneous minor bugfixes #2546

Merged
merged 3 commits into from
Feb 14, 2025
Merged

--[Bugfix] - Miscellaneous minor bugfixes #2546

merged 3 commits into from
Feb 14, 2025

Conversation

jturner65
Copy link
Contributor

Motivation and Context

A few minor bugfixes

  1. render_camera references in mod_viewer needed to be fixed, and an extraneous print statement commented out.
  2. Attributes' source file directories needed a bit more consistent setting.

How Has This Been Tested

Locally c++ and python tests pass

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jturner65 jturner65 requested a review from aclegg3 February 14, 2025 19:35
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Feb 14, 2025
aclegg3
aclegg3 approved these changes Feb 14, 2025
View reviewed changes
Copy link
Contributor

@aclegg3 aclegg3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jturner65 jturner65 merged commit 01d17c7 into main Feb 14, 2025
7 checks passed
@jturner65 jturner65 deleted the Bugfix_misc branch February 14, 2025 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aclegg3 aclegg3 aclegg3 approved these changes

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jturner65 @aclegg3 @facebook-github-bot