-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Fix tensor type checking for pytorch 1.2 #1053
base: main
Are you sure you want to change the base?
Conversation
nice! |
if u try to replace |
I ran into this one as well, ended up with the same fix. Please merge :) |
Hi, Thanks @liyz15 for the fix, I think many of us had this locally, but were too lazy to do a PR :)) so I really appreciate the effort. @zimenglan-sysu-512 Thank you for pointing this out, I have spent a few hours trying to find out which part I messed up by converting all Contacted @fmassa about PRs waiting for review, hopefully we could move the whole project to use pytorch 1.2 and rewrite the INSTALL.md accordingly soon. |
Hi, I've got permission to merge PRs, so we can start updating the lib to use PyTorch v1.2 (or 1.3?) |
Thanks for the fix! |
Fix #725.
In pytorch 1.2, comparison operations return torch.bool instead of torch.uint8, which causes the error.
Ideally we should change all mask to torch.bool. Indexing with torch.uint8 also leads to infinite warning.