-
-
Notifications
You must be signed in to change notification settings - Fork 949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: retry verify tag 3 times #3395
Conversation
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #3395 +/- ##
==========================================
- Coverage 99.97% 99.97% -0.01%
==========================================
Files 2811 2811
Lines 216965 216965
Branches 942 942
==========================================
- Hits 216914 216912 -2
- Misses 51 53 +2 |
060a71f
to
b1ab828
Compare
Pros: Fixes issues with some tests I think the cons don't matter that much as the changed tests have a different purpose. |
Retries the test 3 times, because locally it errors for me very often when I do a first run.
Looks like this even happens on GitHub CI: https://github.com/faker-js/faker/actions/runs/13203808509/job/36862047625?pr=3394#step:7:3071