Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(priority): invert semver matching to avoid unfound semver #462

Merged
merged 2 commits into from
Aug 4, 2023

Conversation

jhonrocha
Copy link
Contributor

@jhonrocha jhonrocha commented Aug 3, 2023

This PR is a fix suggestion.
fix #452

Checklist

Copy link
Collaborator

@simoneb simoneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't look like a sound solution to the issue. I would handle the unexpected value from the fetch-metadata action more explicitly. When we get null, we break.

Also, this needs to be covered by tests

@jhonrocha jhonrocha requested a review from simoneb August 4, 2023 16:05
@simoneb simoneb merged commit 459171f into fastify:main Aug 4, 2023
5 checks passed
@github-actions github-actions bot mentioned this pull request Aug 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Major version update is auto-merged with target set to minor
2 participants