Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tagを打った際にCIで配布ファイルを生成し、新規Releaseを作りつつ添付するアクションを追加 #261

Merged
merged 36 commits into from
Mar 15, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
efebf14
remove unnecessary `/admin/index.php` .
uzulla Mar 7, 2021
b46226a
remove unnecessary `config_loading_include.php`, refactoring `/index.…
uzulla Mar 7, 2021
159cb0f
move admin page assets `public/admin/assets` to `public/assets/admin`
uzulla Mar 7, 2021
0b92078
fix sample .env: wrong BASE_URL
uzulla Mar 7, 2021
b0f7d38
improve: $urls['path'] property could be un exists. ex: `//admin`
uzulla Mar 7, 2021
ea604a4
Fix admin page routing.
uzulla Mar 7, 2021
850b9cc
Improve error message when try to use reserved word in create new blog.
uzulla Mar 7, 2021
a42527b
Add mysql shell start task to Makefile.
uzulla Mar 7, 2021
e51fae8
fix typo
uzulla Mar 7, 2021
3c80737
update phpunit.xsd url
uzulla Mar 7, 2021
2c1a686
Refactoring: move `app/core/*` to `app/src/include`. tidy up config a…
uzulla Mar 7, 2021
bd57d9b
fix path.
uzulla Mar 7, 2021
c87dc89
Refactoring: move `app/config/*` to `app/src/config`. tidy up config …
uzulla Mar 7, 2021
fa2fc93
update testblog1 template.
uzulla Mar 7, 2021
6a934e1
remove debug log.
uzulla Mar 7, 2021
0ef67ad
Update build script that create distribution zip. and README.
uzulla Mar 7, 2021
7318f38
Change build distribution file name. fc2.zip to fc2blog_dist.zip
uzulla Mar 11, 2021
452e423
Implement Fc2blog installer script.
uzulla Mar 12, 2021
d02aa43
Chore. improve repo URL configurability.
uzulla Mar 13, 2021
f2ab35f
Refactoring.
uzulla Mar 13, 2021
ba97370
rewrite copy_r function by php.
uzulla Mar 13, 2021
4e70380
update README
uzulla Mar 13, 2021
cc99c41
update wording.
uzulla Mar 13, 2021
ec32b91
Escape quote.
uzulla Mar 13, 2021
20fce70
re-run test.
uzulla Mar 13, 2021
407121a
re-run test
uzulla Mar 13, 2021
72168ea
Add tweak for the mysterious e2e test failure .
uzulla Mar 13, 2021
e1c3553
Improve make dist zip task #39 #233
uzulla Mar 14, 2021
c621d91
Add create release zip gh action #39 #233
uzulla Mar 14, 2021
04dd28a
update gitignore
uzulla Mar 14, 2021
2b7762d
bugfix
uzulla Mar 14, 2021
81b1e12
quiet output, add debug log.
uzulla Mar 14, 2021
174c0c9
make version file by gh action.
uzulla Mar 14, 2021
4ab4802
make version string from github.ref
uzulla Mar 14, 2021
4e71068
It works #39 #233
uzulla Mar 14, 2021
e55cb85
add some tweak for ci.
uzulla Mar 15, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 64 additions & 0 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,64 @@
name: release

on:
push:
tags:
- 'v*'

jobs:
release:

runs-on: ubuntu-latest

steps:
- name: Setup PHP 8.0
uses: shivammathur/setup-php@v2
with:
php-version: '8.0'
extensions: mbstring, gd, gettext, fileinfo, pdo, pdo_mysql, mysqli, zip

- uses: actions/checkout@v2

- name: get composer
run: |
curl -sSfL -o composer-setup.php https://getcomposer.org/installer
php composer-setup.php --filename=composer.phar
rm composer-setup.php

- name: composer install
run: php composer.phar install --no-ansi --no-interaction --no-scripts --no-progress

- name: pre build
run: |
cd dist_zip && make pre-build

- name: create version file
run: |
VERSION=$(echo ${{ github.ref }} | sed -e "s#refs/tags/##g")
cd dist_zip && echo $VERSION > fc2blog/app/version

- name: make zip
run: |
cd dist_zip && make make-zip

- name: create release
id: create_release
uses: actions/[email protected]
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
tag_name: ${{ github.ref }}
release_name: Release ${{ github.ref }}
draft: false
prerelease: false

- name: attach zip
id: upload-release-asset
uses: actions/[email protected]
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
upload_url: ${{ steps.create_release.outputs.upload_url }}
asset_path: dist_zip/fc2blog_dist.zip
asset_name: fc2blog_dist.zip
asset_content_type: application/zip
8 changes: 8 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,14 @@ docker-compose-build:
$(eval GID := $(shell id -g))
@docker-compose build --build-arg PUID=$(UID) --build-arg PGID=$(GID) php

.PHONY: mysql-shell
mysql-shell:
$(dexec_tty) make d-mysql-shell

.PHONY: d-mysql-shell
d-mysql-shell:
mysql -u $(FC2_DB_USER) -p$(FC2_DB_PASSWORD) -h $(FC2_DB_HOST) -P $(FC2_DB_PORT) "$(FC2_DB_DATABASE)"

.PHONY: db-dump-schema
db-dump-schema:
$(dexec) make d-db-dump-schema
Expand Down
3 changes: 0 additions & 3 deletions app/config.sample.php
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,3 @@
// publicとappの位置関係を修正した場合には変更してください
// Please edit the path when change `app` and `public` relative path condition.
define('WWW_DIR', __DIR__ . '/../public/'); // this path need finish with slash.

// 設定クラス読み込み
require(__DIR__ . '/core/bootstrap.php');
4 changes: 0 additions & 4 deletions app/config_read_from_env.php
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,4 @@
// Please edit the path when change `app` and `public` relative path condition.
define('WWW_DIR', (string)getenv("FC2_DOCUMENT_ROOT_PATH"));

//define('DEFAULT_BLOG_ID', (string)getenv("DEFAULT_BLOG_ID"));
define("DEFAULT_BLOG_ID", (string)getenv("FC2_DEFAULT_BLOG_ID"));

// 設定クラス読み込み
require(__DIR__ . '/core/bootstrap.php');
13 changes: 0 additions & 13 deletions app/include/index_include.php

This file was deleted.

3 changes: 3 additions & 0 deletions app/locale/en_US.UTF-8/LC_MESSAGES/messages.po
Original file line number Diff line number Diff line change
Expand Up @@ -2500,3 +2500,6 @@ msgstr ""

msgid "Host port"
msgstr ""

msgid "Name that cannot be specified"
msgstr ""
Binary file modified app/locale/ja_JP.UTF-8/LC_MESSAGES/messages.mo
Binary file not shown.
3 changes: 3 additions & 0 deletions app/locale/ja_JP.UTF-8/LC_MESSAGES/messages.po
Original file line number Diff line number Diff line change
Expand Up @@ -2547,3 +2547,6 @@ msgstr "(パスワードを変更しない場合、空欄のままとしてく

msgid "Host port"
msgstr "ホスト ポート番号"

msgid "Name that cannot be specified"
msgstr "指定できない名称です"
2 changes: 1 addition & 1 deletion app/src/App.php
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ public static function getBlogLayer(string $blog_id): string
public static function getUserFilePath(array $file, $abs = false, $timestamp = false): string
{
$file_path = static::getBlogLayer($file['blog_id']) . '/file/' . $file['id'] . '.' . $file['ext'];
return ($abs ? Config::get('WWW_UPLOAD_DIR') : '/' . Config::get('UPLOAD_DIR_NAME') . '/') . $file_path . ($timestamp ? '?t=' . strtotime($file['updated_at']) : '');
return ($abs ? Config::get('WWW_UPLOAD_DIR') : '/uploads/') . $file_path . ($timestamp ? '?t=' . strtotime($file['updated_at']) : '');
}

/**
Expand Down
2 changes: 1 addition & 1 deletion app/src/Model/BlogTemplatesModel.php
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ public static function getCssFilePath($blog_id, $device_type, $isPreview = false
*/
public static function getCssUrl($blog_id, $device_type, $isPreview = false)
{
return '/' . Config::get('UPLOAD_DIR_NAME') . '/' . App::getBlogLayer($blog_id) . '/' . $device_type . '/' . ($isPreview ? 'preview' : 'index') . '.css';
return '/uploads/' . App::getBlogLayer($blog_id) . '/' . $device_type . '/' . ($isPreview ? 'preview' : 'index') . '.css';
}

/**
Expand Down
10 changes: 8 additions & 2 deletions app/src/Model/BlogsModel.php
Original file line number Diff line number Diff line change
Expand Up @@ -71,11 +71,17 @@ public static function isPasswordRegistered($blog_id)
* @param string $value
* @return bool|string
*/
public static function useDirectory(string $value)
public static function usableDirectory(string $value)
{
// adminは予約済み
if ($value === "admin"){
return __('Name that cannot be specified');
}

if (is_dir(Config::get('WWW_DIR') . $value)) {
return __('Is already in use');
}

return true;
}

Expand All @@ -96,7 +102,7 @@ public function validate(array $data, ?array &$valid_data = [], array $white_lis
'maxlength' => array('max' => 50),
'alphanumeric' => array(),
'strtolower' => array(),
'own' => array('method' => 'useDirectory'),
'own' => array('method' => 'usableDirectory'),
'unique' => array(),
),
'name' => array(
Expand Down
2 changes: 1 addition & 1 deletion app/src/Web/Request.php
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ public function __construct(
$this->cookie = $cookie ?? $_COOKIE;

$urls = parse_url($this->uri);
$this->path = $urls['path'];
$this->path = $urls['path'] ?? '';
if (isset($urls['query'])) {
$this->query = $urls['query'];
parse_str($urls['query'], $this->get);
Expand Down
2 changes: 1 addition & 1 deletion app/src/Web/Router/Router.php
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ public function __construct(Request $request)
$args_controller = "mode";
$args_action = "process";

if (preg_match('|\A/admin/|u', $request->uri)) { // Admin routing
if (preg_match('!\A(/admin\z|/admin/)!u', $request->uri)) { // Admin routing
// http://example.jp/admin/* が対応
$request->urlRewrite = true;
$request->baseDirectory = '/admin/';
Expand Down
File renamed without changes.
12 changes: 4 additions & 8 deletions app/config/init_config.php → app/src/config/init_config.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,11 @@

// -------------------- ディレクトリ構造関連 --------------------//

$config['ROOT_DIR'] = realpath(__DIR__ . '/../../') . '/';
$config['WWW_DIR'] = WWW_DIR;
$config['WWW_UPLOAD_DIR'] = $config['WWW_DIR'] . 'uploads/';

$config['UPLOAD_DIR_NAME'] = 'uploads';

$config['WWW_DIR'] = defined('WWW_DIR') ? WWW_DIR : $config['ROOT_DIR'] . 'public/';
$config['WWW_UPLOAD_DIR'] = $config['WWW_DIR'] . $config['UPLOAD_DIR_NAME'] . '/';

$config['APP_DIR'] = defined('APP_DIR') ? APP_DIR : $config['ROOT_DIR'] . 'app/';
$config['CONFIG_DIR'] = $config['APP_DIR'] . 'config/';
$config['APP_DIR'] = APP_DIR;
$config['CONFIG_DIR'] = $config['APP_DIR'] . 'src/config/';
$config['LOCALE_DIR'] = $config['APP_DIR'] . 'locale/';
$config['VIEW_DIR'] = $config['APP_DIR'] . 'view/';
$config['TEMP_DIR'] = $config['APP_DIR'] . 'temp/';
Expand Down
2 changes: 1 addition & 1 deletion app/core/bootstrap.php → app/src/include/bootstrap.php
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?php

define('REQUEST_MICROTIME', microtime(true)); // 開始タイムスタンプ(ミリ秒含む)
define('APP_DIR', realpath(__DIR__ . '/../') . '/'); // APPディレクトリのパス
define('APP_DIR', realpath(__DIR__ . '/../../') . '/'); // APPディレクトリのパス

// DBの接続ライブラリ
if (class_exists('mysqli')) {
Expand Down
File renamed without changes.
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
<?php

declare(strict_types=1);

require_once(__DIR__ . '/../../vendor/autoload.php');

// config.phpの存在チェック
if (!file_exists(__DIR__ . '/../config.php') && (string)getenv("FC2_CONFIG_FROM_ENV") !== "1") {
if (!file_exists(__DIR__ . '/../../config.php') && (string)getenv("FC2_CONFIG_FROM_ENV") !== "1") {
header("Content-Type: text/html; charset=UTF-8");
echo <<<HTML
<!DOCTYPE html>
Expand All @@ -20,8 +25,16 @@
exit;
}

// 設定クラス読み込み
if ((string)getenv("FC2_CONFIG_FROM_ENV") === "1") {
require(__DIR__ . '/../config_read_from_env.php');
require(__DIR__ . '/../../config_read_from_env.php');
} else {
require(__DIR__ . '/../config.php');
require(__DIR__ . '/../../config.php');
}
require(__DIR__ . '/bootstrap.php');

$request = new \Fc2blog\Web\Request();

$c = new $request->className($request);
$c->execute($request->methodName);
$c->emit();
2 changes: 1 addition & 1 deletion app/twig_templates/admin/blog_plugins/form_js.twig
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<script type="text/javascript" src="/admin/assets/js/syntax_check.js"></script>
<script type="text/javascript" src="/assets/admin/js/syntax_check.js"></script>

<script>
var template_syntaxes = {{ template_syntaxes|json_encode()|raw }};
Expand Down
2 changes: 1 addition & 1 deletion app/twig_templates/admin/blog_plugins/index_sp.twig
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
{% block title %}{{ _('Plugin management') }}{% endblock %}

{% block content %}
<script type="text/javascript" src="/admin/assets/js/jquery/jquery-toggles/toggles.min.js"></script>
<script type="text/javascript" src="/assets/admin/js/jquery/jquery-toggles/toggles.min.js"></script>

<header><h1 class="sh_heading_main_b">{{ _('Plugin management') }}</h1></header>

Expand Down
2 changes: 1 addition & 1 deletion app/twig_templates/admin/blog_templates/form_js.twig
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<script type="text/javascript" src="/admin/assets/js/syntax_check.js"></script>
<script type="text/javascript" src="/assets/admin/js/syntax_check.js"></script>
<script>
var template_syntaxes = {{ template_syntaxes|json_encode()|raw }};
</script>
2 changes: 1 addition & 1 deletion app/twig_templates/admin/categories/create_sp.twig
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
{% block title %}{{ _('Category management') }}{% endblock %}

{% block content %}
<link rel="stylesheet" href="/admin/assets/css/sp/category_sp.css" type="text/css" media="all">
<link rel="stylesheet" href="/assets/admin/css/sp/category_sp.css" type="text/css" media="all">

<header><h1 class="in_menu sh_heading_main_b"><span class="h1_title">{{ _('Category management') }}</span></h1></header>

Expand Down
2 changes: 1 addition & 1 deletion app/twig_templates/admin/comments/index.twig
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
<input type="submit" value="{{ _('Search') }}"/>
</form>
</div>
<script src="/admin/assets/js/search_form.js" type="text/javascript" charset="utf-8"></script>
<script src="/assets/admin/js/search_form.js" type="text/javascript" charset="utf-8"></script>

{% include('admin/common/paging.twig') %}

Expand Down
2 changes: 1 addition & 1 deletion app/twig_templates/admin/comments/index_sp.twig
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
</div>
</form>
</div>
<script src="/admin/assets/js/search_form.js" type="text/javascript" charset="utf-8"></script>
<script src="/assets/admin/js/search_form.js" type="text/javascript" charset="utf-8"></script>

<ul class="link_list">
{% for comment in comments %}
Expand Down
16 changes: 8 additions & 8 deletions app/twig_templates/admin/entries/editor_js.twig
Original file line number Diff line number Diff line change
@@ -1,27 +1,27 @@
{% block head_include_css %}
<link rel="stylesheet" href="/assets/js/jquery-ui/jquery-ui.min.css" type="text/css" media="screen">
<link rel="stylesheet" href="/admin/assets/js/elrte/css/elrte.min.css" type="text/css" media="screen">
<link rel="stylesheet" href="/assets/admin/js/elrte/css/elrte.min.css" type="text/css" media="screen">
{% endblock %}

{% block head_include_js %}
{# jquery-ui needs load before time picker. #}
<script type="text/javascript" src="/assets/js/jquery-ui/jquery-ui.min.js"></script>
<script type="text/javascript" src="/admin/assets/js/elrte/js/elrte.full.js"></script>
<script type="text/javascript" src="/assets/admin/js/elrte/js/elrte.full.js"></script>

<!-- elRTE translation messages -->
<script type="text/javascript" src="/admin/assets/js/elrte/js/elRTE.options.js"></script>
<script type="text/javascript" src="/admin/assets/js/elrte/js/i18n/elrte.{{ lang_elrte }}.js"></script>
<script type="text/javascript" src="/assets/admin/js/elrte/js/elRTE.options.js"></script>
<script type="text/javascript" src="/assets/admin/js/elrte/js/i18n/elrte.{{ lang_elrte }}.js"></script>
<!-- /elRTE -->

<!-- timepicker-addon -->
<script type="text/javascript" src="/admin/assets/js/jquery/jquery-timepicker-addons/jquery-ui-timepicker-addon.js"></script>
<script type="text/javascript" src="/assets/admin/js/jquery/jquery-timepicker-addons/jquery-ui-timepicker-addon.js"></script>
{% if lang != 'en' %}
<script type="text/javascript" src="/admin/assets/js/jquery/jquery-timepicker-addons/i18n/jquery-ui-timepicker-{{ lang }}.js"></script>
<script type="text/javascript" src="/assets/admin/js/jquery/jquery-timepicker-addons/i18n/jquery-ui-timepicker-{{ lang }}.js"></script>
{% endif %}
<!-- /timepicker-addon -->

<script type="text/javascript" src="/assets/js/js.cookie.js"></script>
<script type="text/javascript" src="/admin/assets/js/entry_editor.js"></script>
<script type="text/javascript" src="/assets/admin/js/entry_editor.js"></script>
{% endblock %}

<!-- メディアを追加する -->
Expand Down Expand Up @@ -147,7 +147,7 @@
height: 450,
toolbar: 'custome',
lang: '{{ lang_elrte }}',
cssfiles: ['/admin/assets/js/elrte/css/elrte-inner.css']
cssfiles: ['/assets/admin/js/elrte/css/elrte-inner.css']
}

var isSetupString = false;
Expand Down
12 changes: 6 additions & 6 deletions app/twig_templates/admin/entries/form_sp.twig
Original file line number Diff line number Diff line change
@@ -1,20 +1,20 @@
{% block head_include_css %}
<link rel="stylesheet" href="/admin/assets/css/sp/category_sp.css" type="text/css" media="all">
<link rel="stylesheet" href="/admin/assets/css/sp/entry_sp.css" type="text/css">
<link rel="stylesheet" href="/assets/admin/css/sp/category_sp.css" type="text/css" media="all">
<link rel="stylesheet" href="/assets/admin/css/sp/entry_sp.css" type="text/css">
{% endblock %}
{% block head_include_js %}
<!-- timepicker-addon -->
<script type="text/javascript" src="/admin/assets/js/jquery/jquery-timepicker-addons/jquery-ui-timepicker-addon.js"></script>
<script type="text/javascript" src="/assets/admin/js/jquery/jquery-timepicker-addons/jquery-ui-timepicker-addon.js"></script>
{% if lang != 'en' %}
<script type="text/javascript" src="/admin/assets/js/jquery/jquery-timepicker-addons/i18n/jquery-ui-timepicker-{{ lang }}.js"></script>
<script type="text/javascript" src="/assets/admin/js/jquery/jquery-timepicker-addons/i18n/jquery-ui-timepicker-{{ lang }}.js"></script>
{% endif %}
<!-- /timepicker-addon -->

<script type="text/javascript" src="/assets/js/js.cookie.js"></script>
<script type="text/javascript" src="/admin/assets/js/entry_editor.js"></script>
<script type="text/javascript" src="/assets/admin/js/entry_editor.js"></script>
{% endblock %}

<script type="text/javascript" src="/admin/assets/js/jquery/jquery.fc2tab.js"></script>
<script type="text/javascript" src="/assets/admin/js/jquery/jquery.fc2tab.js"></script>
<script type="text/javascript">
$(function () {
// 記事 or 追記のタブ
Expand Down
2 changes: 1 addition & 1 deletion app/twig_templates/admin/entries/index.twig
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
<input type="submit" value="{{ _('Search') }}"/>
</form>
</div>
<script src="/admin/assets/js/search_form.js" type="text/javascript" charset="utf-8"></script>
<script src="/assets/admin/js/search_form.js" type="text/javascript" charset="utf-8"></script>

{% include('admin/common/paging.twig') %}

Expand Down
2 changes: 1 addition & 1 deletion app/twig_templates/admin/entries/index_sp.twig
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
</div>
</form>
</div>
<script src="/admin/assets/js/search_form.js" type="text/javascript" charset="utf-8"></script>
<script src="/assets/admin/js/search_form.js" type="text/javascript" charset="utf-8"></script>

<form method="POST" id="sys-list-form">
<ul class="link_list">
Expand Down
6 changes: 3 additions & 3 deletions app/twig_templates/admin/layouts/default.twig
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@
<link rel="stylesheet" href="/assets/css/normalize.css" type="text/css" media="all">
<link rel="stylesheet" href="/assets/css/common.css" type="text/css" media="all">
<link rel="stylesheet" href="/assets/css/main.css" type="text/css" media="all">
<link rel="stylesheet" href="/admin/assets/css/admin-fc2.css" type="text/css" media="all">
<link rel="stylesheet" href="/admin/assets/css/admin-form.css" type="text/css" media="all">
<link rel="stylesheet" href="/admin/assets/css/admin_style.css" type="text/css" media="all">
<link rel="stylesheet" href="/assets/admin/css/admin-fc2.css" type="text/css" media="all">
<link rel="stylesheet" href="/assets/admin/css/admin-form.css" type="text/css" media="all">
<link rel="stylesheet" href="/assets/admin/css/admin_style.css" type="text/css" media="all">

{% if block('head_include_css') is defined %}
{{ block('head_include_css') }}
Expand Down
Loading