Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSDB削除、MysqliWrap削除、PDOWrapリファクタ、Model周りリファクタ等 #331 #332

Merged
merged 21 commits into from
Jun 13, 2021
Merged

MSDB削除、MysqliWrap削除、PDOWrapリファクタ、Model周りリファクタ等 #331 #332

merged 21 commits into from
Jun 13, 2021

Conversation

uzulla
Copy link
Collaborator

@uzulla uzulla commented Jun 13, 2021 •
edited
Loading

ref #331 #80

  • MSDBの削除
  • MysqliWrapperの削除（PDO一本化）
  • Modelなどの修正
  • PDOWrapへの統合
  • PDOWrapとModelのリファクタリング
  • PDOWrapをPDOConnectionとPDOQueryに分割（コネクション管理と、クエリ発行管理）
  • ModelからQueryTraitへSQL生成（PDOQueryをコールするもの）系を分割
  • 仕様変更にともなうInstallerの修正
  • Install前にクエリが失敗するのを許容（$blogs_model->getSelectList($this->getUserId())）
  • 各種Modelのリファクタリング、型付与
  • モデルおよびPDOWrapのシングルトン全廃にむけて準備 DB操作時のトランザクションがない #80

作業時間5h

uzulla added 17 commits June 13, 2021 18:29
@uzulla
remove MysqliWrap. fc2blog#332
948ab47
@uzulla
remove unnecessary getVersion. fc2blog#332
226ffb6
@uzulla
refactoring the PDOWrap class. fc2blog#332
d641d4f
@uzulla
Bugfix, Now the getFoundRows method works correctly with PDO. fc2blog…
e941574 
…#332
@uzulla
remove auto select feature of mysqli or pdo. fc2blog#332
a709a87
@uzulla
Remove the installation ext-mysqli in CI. fc2blog#332
70f5d0e
@uzulla
Remove the check ext-mysqli available in the installer. fc2blog#332
fd3b2fd
@uzulla
Remove the check ext-mysqli available in the installer' test. fc2blog…
aef47ec 
…#332
@uzulla
Update text in the installer. fc2blog#332
7b7032c
@uzulla
Chore, set correct types.
3ba7fd5
@uzulla
use PDOWrap instead of DBInterface, update the (base) Model class, re…
228d47a 
…move MSDB. fc2blog#332
@uzulla
Use directly to the PDOWrap class instead of the DBInterface. fc2blog…
2676202 
…#332
@uzulla
Remove check for UTF8MB4 support (too old mysql).
fefed24
@uzulla
Refactoring PDOWrap. fc2blog#332
25d4b17
@uzulla
Bugfix, query failed in install. fc2blog#332
faacfbf
@uzulla
Bugfix
9c56b01
@uzulla
Now unnecessary old_log method. removed.
79d5015
@fc2dev fc2dev marked this pull request as ready for review June 13, 2021 11:13
@uzulla uzulla changed the title Issue332/remove mysqli support MSDB削除、MysqliWrap削除、PDOWrapリファクタ、Model周りリファクタ等 #332 Jun 13, 2021
@uzulla uzulla changed the title MSDB削除、MysqliWrap削除、PDOWrapリファクタ、Model周りリファクタ等 #332 MSDB削除、MysqliWrap削除、PDOWrapリファクタ、Model周りリファクタ等 #331 Jun 13, 2021
@fc2dev fc2dev merged commit 90ccdd7 into fc2blog:master Jun 13, 2021
@uzulla uzulla deleted the issue332/remove-mysqli-support branch July 31, 2021 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uzulla @fc2dev