Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add $:/plugins/Gk0Wk/focused-tiddler #464

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

linonetwo
Copy link

closes #462

I test this locally, live view works fine

@linonetwo
Copy link
Author

截屏2024-10-12 17 23 31

And it works well with TidGi setup, despite that it add tmap.id to every existing tiddlers, even those not on the map.

@flibbles
Copy link
Collaborator

Okay. I might be going insane.

I can't find this focussedTiddler anywhere. The link I'm seeing in #462 goes to this CPL website that only has a blurb. There's nothing to drag-and-drop, there's no github link. There's no plugin as far as I can tell. Google can't find it either. Am I stupid? I can't find the actual plugin to link to (because the README file for this project would need to be updated to point to it.)

Also, I looked into removing tmap.id. It's a huge endeavor. I partially wrote some of the migrators that would need to be created, and maybe once I finish my current project, I might look into it more. But holy shit would it be a lot of work.

@flibbles
Copy link
Collaborator

Okay. I found the plugin in the CPL website, but only by going into its configuration (which it tries to hide). But that's not something to link to. It's hardly forward-facing, and the code is already uglified. Is there a source project somewhere? Even Gk0Wk's github profile itself doesn't have this project.

@linonetwo
Copy link
Author

linonetwo commented Oct 12, 2024

Sorry, it is at https://github.com/Gk0Wk/TiddlySeq/tree/master/src/focused-tiddler , Gk0Wk forget to fill-in the repo field in CPL, I'm going to add it.


Updated on CPL, site update in 10 mins.

@flibbles
Copy link
Collaborator

I guess what I should have asked is if there is a link to an actual plugin json file or something they can drag and drop. This repository doesn't have a bundled build. And since it's using ".ts" files (!?!?!??!), I assume it needs to be built, but there is no build file. Also, the README file isn't really markdown. This looks like a very ugly project to direct end-users to.

Are you SURE this is well maintained? I'm a Tiddlywiki power user, and even I would have given up trying to use this plugin if I needed its functionality.

@flibbles
Copy link
Collaborator

You know, maybe the proper solution here is to remove Hotzone and focussedTiddler as requirements. Because they're not. You only need them if you want "Live View" to constantly refresh to whatever tiddler you happen to scroll to.

Maybe remove them from the requirements, and just put a comment in TiddlyMap README that you can install them if you want that functionality. And maybe link to HotZone or focused-tiddler.

But focused-tiddler would still need a link to a bundle.

@linonetwo
Copy link
Author

linonetwo commented Oct 13, 2024

I've just wake up.

The JSON can be downloaded from the url in cpl.uri field on tiddler on CPL. And the Readme isn't for Github, only few people read it (see how many star it has), it is only for CPL. At least it looks good on CPL, and even has i18n.

图片

Its TS is build by Tiddly.ModernDev, which is run in the Github Action, you can see the detailed steps in the action file. And I think it use extra steps to build a plugin library

It is only 4.6k, very small dep, and installing it is important to prevent new user complain about things not working.

图片

But we can put a comment to say you can safely uncheck it when install

图片

@flibbles
Copy link
Collaborator

flibbles commented Nov 8, 2024

I have finally found the time and patience to try this focused-tiddler plugin.

I do not like it.

Yes, it works, but why? You say "new user complain about things not working". What? Where? How? I see nothing wrong with it.

Hotzone has a simple repository. It does not require a build process. Meanwhile, focused-tiddler comes with a plethora of unrelated plugins. It requires a build process which, I think, involves npm? I wouldn't know, because there are zero build instructions. the README for the repository just says "View Demo", but not only does the demo not have any build instructions. It doesn't even feature focused-tiddler. I had to dig around in the hidden control panel to even find it.

Maybe I could make this plugin work for people who use tiddlymap with standalone files by providing something they can drag-and-drop. But anyone using Node.JS (like me), will have a hell of a time getting a proper build of focused-tiddler to work. I had to make mine. By hand. By copying over each file individually. (Because again, no build instructions.)

Why does such a simple plugin even require a build process? Wouldn't it be simpler just to fix Hotzone for whatever problems it has? I could fork that and fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

replace TW5-HotZone with focusedTiddler plugin
2 participants