Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update SDK to use fetchEvent #244

Merged
merged 7 commits into from
Jun 17, 2024

Conversation

karthik2804
Copy link
Collaborator

The templates have not been updated since there is a release of the SDK and we cannot use a git reference as this repository does not check in artifacts.

Still a work in progress because it needs a little more testing as well as needs to be updated once a fix for bytecodealliance/StarlingMonkey#52 (comment) is pushed.

@bacongobbler
Copy link
Member

Note that we will need to update the Vue and Nuxt examples in #236 and #233.

Signed-off-by: karthik2804 <[email protected]>
Signed-off-by: karthik2804 <[email protected]>

pull in latest changes

Signed-off-by: karthik2804 <[email protected]>
@karthik2804 karthik2804 marked this pull request as ready for review June 13, 2024 10:03
Signed-off-by: karthik2804 <[email protected]>
Copy link
Contributor

@tschneidereit tschneidereit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I left a few comments which should be addressed, but once those are in, this looks ready

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
templates/http-ts/content/src/spin.ts Outdated Show resolved Hide resolved
templates/http-ts/content/src/spin.ts Outdated Show resolved Hide resolved
templates/http-ts/content/src/spin.ts Outdated Show resolved Hide resolved
templates/http-ts/content/package.json Outdated Show resolved Hide resolved
templates/http-ts/content/src/index.ts Outdated Show resolved Hide resolved
src/inboundHttp.ts Outdated Show resolved Hide resolved
src/inboundHttp.ts Outdated Show resolved Hide resolved
Signed-off-by: karthik2804 <[email protected]>
@karthik2804 karthik2804 changed the title (WIP): update SDK to use fetchEvent update SDK to use fetchEvent Jun 17, 2024
@karthik2804 karthik2804 merged commit e7d67ab into fermyon:feat/sdk-v2 Jun 17, 2024
2 checks passed
@karthik2804 karthik2804 deleted the update_to_fetch_event branch June 17, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants