Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Dockerfile.deps): switch to python:alpine base image #758

Merged
merged 1 commit into from
Mar 7, 2025

Conversation

Gearheads
Copy link
Collaborator

@Gearheads Gearheads commented Mar 4, 2025

What this PR does / why we need it:
This change will avoid using the Microsoft Azure CLI Docker image, because the newer versions contain Azure Linux operating system instead of Alpine. This change in operating system can cause issues for users building on top of this image. Therefore introducing a breaking change, which I think we should try to avoid.

I used this GitHub issue for reference: Azure/azure-cli#19591

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes # The new mcr.microsoft.com/azure-cli:2.67.0 Docker image has migrated to using Azure Linx instead of Alpine for the underlying operating system: https://learn.microsoft.com/en-us/cli/azure/run-azure-cli-docker?view=azure-cli-latest

This causes the current Dockerfile.deps to fail during the goreleaser GitHub Action:

> [stage-1  2/10] RUN apk --no-cache add ca-certificates:
0.146 /bin/sh: line 1: apk: command not found
------
Dockerfile:41
--------------------
  39 |     # Azure CLI
  40 |     FROM mcr.microsoft.com/azure-cli:2.67.0
  41 | >>> RUN apk --no-cache add ca-certificates
  42 |     
  43 |     WORKDIR /app/
--------------------
ERROR: failed to solve: process "/bin/sh -c apk --no-cache add ca-certificates" did not complete successfully: exit code: 127

https://github.com/fidelity/kconnect/actions/runs/13575743025/job/37951438546

Testing

I created a Pre-release tag on this bugfix branch to make sure that these changes would pass the goreleaser GitHub Action.
https://github.com/fidelity/kconnect/actions/runs/13640814861

This branch can be deleted once it is merged.

This change will avoid using the Microsoft Azure CLI image, because the newer versions contain Azure Linux operating system instead of Alpine. This change in operating system can cause issues for user building on top of this image. Therefore introducing a breaking change, which I think we should try to avoid.

Signed-off-by: Casale, Robert <[email protected]>
@Gearheads Gearheads merged commit 57935b1 into main Mar 7, 2025
15 checks passed
@Gearheads Gearheads deleted the bugfix/azure-cli-image branch March 7, 2025 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants