Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update requirements.txt #16

Merged
merged 3 commits into from
Sep 9, 2024
Merged

Update requirements.txt #16

merged 3 commits into from
Sep 9, 2024

Conversation

kuppulur
Copy link
Contributor

@kuppulur kuppulur commented Sep 9, 2024

bpemb became an optional requirement for Flair. So, I had to add it to our current requirements, to make sure our tests which require bpemb to pass.

Signed-off-by: Karthik Uppuluri <[email protected]>
@kuppulur kuppulur added the WIP label Sep 9, 2024
@kuppulur kuppulur requested a review from skadio September 9, 2024 14:26
@kuppulur kuppulur removed the WIP label Sep 9, 2024
Copy link
Contributor

@skadio skadio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Please also update the version and changelog, and i assume you will take care of PyPi and release tag

Signed-off-by: Karthik Uppuluri <[email protected]>
Signed-off-by: Karthik Uppuluri <[email protected]>
@kuppulur kuppulur merged commit 7593961 into master Sep 9, 2024
6 checks passed
@kuppulur kuppulur deleted the fix/bpemb_ci_issue branch September 9, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants