Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fip-0100: add daily_proof_fee() and fee constants #1621

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Feb 14, 2025

Stacking a PR here so it's mainly asking for a sanity-check review and checking if anything's out of place or I'm not following convention.

Stacked on #1620 for the feat/fip-0100 branch.

Closes: #1612

Added a test to sanity check, it also ~matches what was given as a current-day estimate here.

@rvagg rvagg force-pushed the rvagg/fip-0100/fee-calc branch from 122b3d9 to 3dbe0df Compare February 14, 2025 07:09
@rvagg rvagg self-assigned this Feb 14, 2025
@rvagg rvagg force-pushed the rvagg/fip-0100/fee-calc branch from 3dbe0df to cccfdfb Compare February 14, 2025 08:01
Base automatically changed from rvagg/fip-0100-types to feat/fip-0100 February 14, 2025 19:44
@Stebalien Stebalien force-pushed the rvagg/fip-0100/fee-calc branch from cccfdfb to d014397 Compare February 14, 2025 19:46
@Stebalien Stebalien merged commit 77364a4 into feat/fip-0100 Feb 14, 2025
11 checks passed
@Stebalien Stebalien deleted the rvagg/fip-0100/fee-calc branch February 14, 2025 20:49
rvagg added a commit that referenced this pull request Feb 19, 2025
* Adds a `daily_proof_fee(policy: &Policy, circulating_supply: TokenAmount)` for the miner actor
* Adds `DAILY_FEE_CIRCULATING_SUPPLY_MULTIPLIER_NUM` and `DAILY_FEE_CIRCULATING_SUPPLY_MULTIPLIER_DENOM` for a 7.4e-15 multiplier as per the FIP: https://github.com/filecoin-project/FIPs/blob/master/FIPS/fip-0100.md#per-sector-fee-added

Added a test to sanity check, it also ~matches what was given as a current-day estimate [here](filecoin-project/FIPs#1105 (comment)).

Closes: #1612
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🎉 Done
Status: 🎉 Done
Development

Successfully merging this pull request may close these issues.

Miner actor: implement function that figures out fee from circulating supply
2 participants