Code Quality: Adding ToolbarButton controls #15894
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is assuming we are building a control from scratch. Code is mostly placeholder and dependency property frameworks
Not sure if this is the right approach, but I've done it for now. ToolbarItem should be an abstract and the Toolbar control translates them into Buttons and Menu Items
Set the window size to be more mangable whilst debugging lol
Basic creation of controls with sizes based on ToolbarSize - we need to re-draw or update controls within the lists if the ToolbarSize changes at runtime
Also added an IsChecked property to ToolbarItem to be passed onto the Toggle ItemTypes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
Creating a bespoke control for use in Files' toolbars and address bar. Uses our ThemedIcon control.
Ensuring @0x5bfa is ok with working on this control, and @yaira2 to keep an eye on it, as we start work on it.
This Pull Request will remain a Draft until it is ready for review and merging
To prevent extra work, all changes to the Files codebase must link to an approved issue marked as
Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.Steps used to test these changes
Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.