Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Quality: WinAppSdk 1.6 #16156

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Code Quality: WinAppSdk 1.6 #16156

wants to merge 10 commits into from

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Sep 8, 2024

  • Updated WinAppSdk to 1.6
  • Removed workaround for auto hide taskbar

@yaira2 yaira2 marked this pull request as draft September 8, 2024 16:24
@f1amy
Copy link

f1amy commented Sep 9, 2024

Will this utilize new native AOT compilation?

@0x5bfa
Copy link
Member

0x5bfa commented Sep 9, 2024

Not yet, we have still some blocker (Vanara package). I've been removing it.

@yaira2
Copy link
Member Author

yaira2 commented Sep 9, 2024

Will this utilize new native AOT compilation?

Aside from what @0x5bfa mentioned, the AOT support in WinAppSdk 1.6 is a bit rough and we might have to wait for future versions of WinAppSdk before we can enable it.

@yaira2
Copy link
Member Author

yaira2 commented Sep 11, 2024

The two issues we're currently having with this PR are

  1. The accessibility tests (fyi @marcelwgn)
  2. Shell previews cause Files to crash
    image

@hez2010
Copy link
Member

hez2010 commented Sep 12, 2024

  1. You need to add the latest CsWinRT reference to all projects using WinRT APIs, they have a source generator for this.
  2. You can use <WindowsSdkPackageVersion>10.0.22621.42</WindowsSdkPackageVersion>.
  3. Some classes need to be marked as partial after you update CsWinRT.

@yaira2
Copy link
Member Author

yaira2 commented Sep 12, 2024

You need to add the latest CsWinRT reference to all projects using WinRT APIs, they have a source generator for this.

The last time we tried updating it caused a bunch of crashes, but it could be that updating WinAppSdk will solve this issue.

Some classes need to be marked as partial after you update CsWinRT.

How do you know which ones?

@hez2010
Copy link
Member

hez2010 commented Sep 12, 2024

How do you know which ones?

The analyzer bundled with WinRT will tell you and yield a compilation error if there's anything missing.

@hez2010
Copy link
Member

hez2010 commented Sep 12, 2024

I will check later today.

@yaira2 yaira2 force-pushed the ya/wasdk branch 2 times, most recently from 3a188ed to e7025f3 Compare September 12, 2024 16:29
@yaira2 yaira2 marked this pull request as ready for review September 12, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants