-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code Quality: WinAppSdk 1.6 #16156
base: main
Are you sure you want to change the base?
Code Quality: WinAppSdk 1.6 #16156
Conversation
yaira2
commented
Sep 8, 2024
•
edited
Loading
edited
- Updated WinAppSdk to 1.6
- Removed workaround for auto hide taskbar
Will this utilize new native AOT compilation? |
Not yet, we have still some blocker (Vanara package). I've been removing it. |
Aside from what @0x5bfa mentioned, the AOT support in WinAppSdk 1.6 is a bit rough and we might have to wait for future versions of WinAppSdk before we can enable it. |
The two issues we're currently having with this PR are
|
|
The last time we tried updating it caused a bunch of crashes, but it could be that updating WinAppSdk will solve this issue.
How do you know which ones? |
The analyzer bundled with WinRT will tell you and yield a compilation error if there's anything missing. |
I will check later today. |
3a188ed
to
e7025f3
Compare
This reverts commit d59412d.