Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Quality: Dispose all com instances #16195

Merged
merged 1 commit into from
Sep 29, 2024

Conversation

0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented Sep 15, 2024

Resolved / Related Issues

I forgot dispose some com instances before. Diposed using ComPtr

Steps used to test these changes

You can't check anything.

  • IWindowsWallpaperService
  • IWindowdDialogService
  • IStorageTrashBinService.RestoreAllTrashes

@yaira2
Copy link
Member

yaira2 commented Sep 16, 2024

You can't check anything.

We should confirm the features are all working as expected

@0x5bfa
Copy link
Member Author

0x5bfa commented Sep 21, 2024

All of them work for me.

@yaira2 yaira2 merged commit eee7622 into files-community:main Sep 29, 2024
6 checks passed
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Sep 29, 2024
@0x5bfa 0x5bfa deleted the 5bfa/CQ-ComRelease branch September 29, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants