Fix: Fixed issue with navigating photos on Windows 10 #16232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hishitetsu, it turns out the NeighboringFilesQuery still works on Windows 10 so I added the conditional check I mentioned here #16102 (comment) |
hishitetsu
reviewed
Sep 21, 2024
hishitetsu
approved these changes
Sep 22, 2024
There was a problem hiding this comment.
Should continue to function the way it did before #16102. The truth is #16102 was really only needed to fix a couple of niche cases, none of which were known to affect photos.
I'm wondering if that niche case applies to other photo apps, but there are no code issues, so it is fine to see how it goes.
|
That's a fair point, we'll have to watch for feedback and adjust our approach if necessary. |
yaira2
added
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
To prevent extra work, all changes to the Files codebase must link to an approved issue marked as
Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.Steps used to test these changes
Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.