Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add be_right_back #121

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

MichaelMcClennan
Copy link
Contributor

A temporary floating bookmark. The user 'Sets' the current position ... moves around the score(maybe to copy music) ... 'Goes Back' to the saved position.

A temporary floating bookmark.   The user 'Sets' the current position ... moves around the score(maybe to copy music) ... 'Goes Back' to the saved position.
When you need to send a file for diagnostic reasons(say to MakeMusic), but you don't want to send the real notes.
@rpatters1
Copy link
Collaborator

rpatters1 commented Jan 3, 2022

Great idea for a plugin, and I like your neat readable code. It's amazing what new possibilities a modeless window offers. I have a few suggestions.

  • As a stylistic matter, I don't think boolean values should be compared to true or false. They should just be tested: if BRB_table.page_view then. This is especially true when testing for false conditions, though I did not see an example of that in this script.
  • Because it has to be a modeless dialog, this script should have finaleplugin.MinJWLuaVersion = 0.57 set in the plugindef function. That will prevent it from loading in JW Lua (ironically).
  • The plugindef function should return three strings. (See original JW Lua documentation for details.)
  • I'm concerned that, at least on Windows, the calling of scroll view then page view menu options will cause ugly flickering. FCMusicRegion has a scroll-into-view method that works in either scroll or page view without changing views. (It probably works in Studio View as well, though I haven't tried it.) Look at UI-switch-to-selected-part.lua for examples.
  • But speaking of switching views, should the script remember which view you're in and restore that as well? If so, be careful not to call the menu option for, e.g., page view if you're already in page view because Finale may move the scroll bars.

copies the selected music, and pastes it directly to the right
@Nick-Mazuk
Copy link
Member

Hey @MichaelMcClennan, just wanted to circle back to see if you were still interested in completing this.

@MichaelMcClennan
Copy link
Contributor Author

MichaelMcClennan commented Jul 29, 2022 via email

@Nick-Mazuk
Copy link
Member

No worries at all. Just wanted to check in.

@rpatters1
Copy link
Collaborator

What is the status of this PR? Should we close it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants