Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extended DisplayAttribute support #8

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Extended DisplayAttribute support #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c247bfd
Extended support for display attribute
JabJava Oct 28, 2021
f916778
Update README.md
JabJava Oct 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ If you liked `ExcelExport` project or if it helped you, please give a star ⭐
### Name
Column names in Excel Export can be configured using the below attributes
* `[Display(Name = "")]`
* `[Display(Name = "", ResourceType = typeof(MyResourceFile))]`
* `[DisplayName(“”)]`

### Report Setup
Expand Down
2 changes: 1 addition & 1 deletion src/ApplicationCore/Extensions/PropertyExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ public static string GetPropertyDisplayName(this PropertyInfo propertyInfo)
{
var propertyDescriptor = propertyInfo.GetPropertyDescriptor();
var displayName = propertyInfo.IsDefined(typeof(DisplayAttribute), false) ? propertyInfo.GetCustomAttributes(typeof(DisplayAttribute),
false).Cast<DisplayAttribute>().Single().Name : null;
false).Cast<DisplayAttribute>().Single().GetName() : null;

return displayName ?? propertyDescriptor.DisplayName ?? propertyDescriptor.Name;
}
Expand Down