Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge v11 Feature Branch #8475

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Merge v11 Feature Branch #8475

wants to merge 2 commits into from

Conversation

hsubox76
Copy link
Contributor

@hsubox76 hsubox76 commented Sep 3, 2024

This feature branch is targeted for Oct 1 and is expected to include:

  • Node engines fields set to 18+
  • Remove undici/node-fetch
  • TBD

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 3, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: a377fb2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 3, 2024 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/firestore

    TypeBase (15c36cc)Merge (c0e84ac)Diff
    browser381 kB382 kB+46 B (+0.0%)
    esm5366 kB366 kB+16 B (+0.0%)
    main587 kB587 kB+32 B (+0.0%)
    module381 kB382 kB+46 B (+0.0%)
    react-native382 kB382 kB+46 B (+0.0%)

  • bundle

    TypeBase (15c36cc)Merge (c0e84ac)Diff
    firestore (CSI Auto Indexing Disable and Delete)270 kB273 kB+2.55 kB (+0.9%)
    firestore (CSI Auto Indexing Enable)270 kB273 kB+2.55 kB (+0.9%)
    firestore (Persistence)305 kB308 kB+2.55 kB (+0.8%)
    firestore (Query Cursors)242 kB248 kB+6.23 kB (+2.6%)
    firestore (Query)240 kB246 kB+6.23 kB (+2.6%)
    firestore (Read data once)228 kB234 kB+6.23 kB (+2.7%)
    firestore (Read Write w Persistence)325 kB328 kB+2.55 kB (+0.8%)
    firestore (Realtime updates)230 kB236 kB+6.23 kB (+2.7%)
    firestore (Transaction)207 kB213 kB+6.49 kB (+3.1%)
    firestore (Write data)207 kB213 kB+6.23 kB (+3.0%)

  • firebase

    TypeBase (15c36cc)Merge (c0e84ac)Diff
    firebase-compat.js788 kB791 kB+2.50 kB (+0.3%)
    firebase-firestore-compat.js344 kB346 kB+2.50 kB (+0.7%)
    firebase-firestore.js440 kB440 kB+46 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/uJeKA9lEzN.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 3, 2024 •
edited
Loading

Size Analysis Report 1

This report is too large (513,737 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/5XDwlcb7jX.html

@wu-hui
Make memory lru gc the default (#8110)
a377fb2 
* Make memory lru gc the default

* undo yarn.lock

* Make memory lru gc the default

* Fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avolkovi avolkovi Awaiting requested review from avolkovi avolkovi will be requested when the pull request is marked ready for review avolkovi is a code owner

@sam-gc sam-gc Awaiting requested review from sam-gc sam-gc will be requested when the pull request is marked ready for review sam-gc is a code owner

@yuchenshi yuchenshi Awaiting requested review from yuchenshi yuchenshi will be requested when the pull request is marked ready for review yuchenshi is a code owner

@lisajian lisajian Awaiting requested review from lisajian lisajian will be requested when the pull request is marked ready for review lisajian is a code owner

@Xiaoshouzi-gh Xiaoshouzi-gh Awaiting requested review from Xiaoshouzi-gh Xiaoshouzi-gh will be requested when the pull request is marked ready for review Xiaoshouzi-gh is a code owner

@zwu52 zwu52 Awaiting requested review from zwu52 zwu52 will be requested when the pull request is marked ready for review zwu52 is a code owner

@maneesht maneesht Awaiting requested review from maneesht maneesht will be requested when the pull request is marked ready for review maneesht is a code owner

@tonyjhuang tonyjhuang Awaiting requested review from tonyjhuang tonyjhuang will be requested when the pull request is marked ready for review tonyjhuang is a code owner

@aashishpatil-g aashishpatil-g Awaiting requested review from aashishpatil-g aashishpatil-g will be requested when the pull request is marked ready for review aashishpatil-g is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hsubox76 @google-oss-bot @wu-hui