You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having the stdout and stderr in a single string makes it easier to read when analyzing test failures. Currently if there's a test failure, we output stdout and stderr separately so we can't tell which errors were logged during which test.
Having CI test process stdout and stderr in a single string makes it
easier to read when looking through failures, since you can see the test
output alongside the error messages.
Without this, any stderr output written during a test will be captured
seperately from the test output, so when we then log it after a test
failure, we can't tell which test logged which errors.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if it is ever useful to know which output came out of stdout and which came out of stderr but just in case it might be, do you think we might want to append a prefix like [stdout] or [stderr] before each of these?
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having the
stdoutandstderrin a single string makes it easier to read when analyzing test failures. Currently if there's a test failure, we output stdout and stderr separately so we can't tell which errors were logged during which test.For example, in https://github.com/firebase/firebase-js-sdk/actions/runs/10776099172/job/29882046607, there are tons of
FIREBASE FATAL ERROR's logged, but I can't tell which tests are logging these errors, or if they're even what's causing the tests to fail.