V11 release removal of node-fetch and undici dependencies #8492

DellaBitta · 2024-09-10T15:22:38Z

Discussion

Our v11 release will require node 18+. Since fetch has been introduced in these node versions, we can remove our dependency on third party fetch implementations.

This PR removes our usage of fetch variants undici and node-fetch for our node target builds and our CI tools.

Testing

CI.

API Changes

NA.

changeset-bot · 2024-09-10T15:22:42Z

⚠️ No Changeset found

Latest commit: 498bc7b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

google-oss-bot · 2024-09-10T15:40:00Z

Size Report ¹

Affected Products

@firebase/auth
Type Base (a377fb2) Merge (7f0c024) Diff
main 179 kB 178 kB -74 B (-0.0%)
@firebase/auth-compat
Type Base (a377fb2) Merge (7f0c024) Diff
main 29.5 kB 29.4 kB -74 B (-0.3%)
@firebase/auth/internal
Type Base (a377fb2) Merge (7f0c024) Diff
main 214 kB 214 kB -74 B (-0.0%)
@firebase/firestore-lite
Type Base (a377fb2) Merge (7f0c024) Diff
browser 111 kB 111 kB -56 B (-0.1%)
esm5 108 kB 108 kB -25 B (-0.0%)
main 153 kB 153 kB -156 B (-0.1%)
module 111 kB 111 kB -56 B (-0.1%)
react-native 111 kB 111 kB -56 B (-0.1%)
@firebase/functions
Type Base (a377fb2) Merge (7f0c024) Diff
browser 9.76 kB 9.65 kB -113 B (-1.2%)
esm5 12.1 kB 12.0 kB -113 B (-0.9%)
main 12.8 kB 12.6 kB -163 B (-1.3%)
module 9.76 kB 9.65 kB -113 B (-1.2%)
@firebase/rules-unit-testing
Type Base (a377fb2) Merge (7f0c024) Diff
main 17.8 kB 17.6 kB -228 B (-1.3%)
@firebase/storage
Type Base (a377fb2) Merge (7f0c024) Diff
main 59.4 kB 59.3 kB -90 B (-0.2%)

`bundle`

Type	Base (`a377fb2`)	Merge (`7f0c024`)	Diff
firestore-lite (Query Cursors)	91.3 kB	91.2 kB	-56 B (-0.1%)
firestore-lite (Query)	87.4 kB	87.3 kB	-56 B (-0.1%)
firestore-lite (Read data once)	62.9 kB	62.8 kB	-53 B (-0.1%)
firestore-lite (Transaction)	88.1 kB	88.1 kB	-56 B (-0.1%)
firestore-lite (Write data)	72.5 kB	72.4 kB	-56 B (-0.1%)
functions (call)	32.0 kB	31.9 kB	-49 B (-0.2%)

`firebase`

Type	Base (`a377fb2`)	Merge (`7f0c024`)	Diff
firebase-compat.js	791 kB	791 kB	-55 B (-0.0%)
firebase-firestore-lite.js	119 kB	119 kB	-56 B (-0.0%)
firebase-functions-compat.js	8.22 kB	8.17 kB	-52 B (-0.6%)
firebase-functions.js	12.0 kB	11.9 kB	-49 B (-0.4%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/cIiKtTEZnl.html

google-oss-bot · 2024-09-10T15:52:07Z

Size Analysis Report ¹

Affected Products

@firebase/functions
- connectFunctionsEmulator
  Size
  Type Base (a377fb2) Merge (7f0c024) Diff
  size 2.50 kB 2.46 kB -39 B (-1.6%)
  size-with-ext-deps 20.3 kB 20.3 kB -39 B (-0.2%)
- getFunctions
  Size
  Type Base (a377fb2) Merge (7f0c024) Diff
  size 2.68 kB 2.64 kB -39 B (-1.5%)
  size-with-ext-deps 28.1 kB 28.1 kB -39 B (-0.1%)
- httpsCallable
  Size
  Type Base (a377fb2) Merge (7f0c024) Diff
  size 6.13 kB 6.08 kB -49 B (-0.8%)
  size-with-ext-deps 24.0 kB 23.9 kB -49 B (-0.2%)
- httpsCallableFromURL
  Size
  Type Base (a377fb2) Merge (7f0c024) Diff
  size 6.08 kB 6.03 kB -49 B (-0.8%)
  size-with-ext-deps 23.9 kB 23.9 kB -49 B (-0.2%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/K5reJWKuIs.html

DellaBitta · 2024-09-16T18:27:29Z

packages/auth-compat/index.node.ts

-  fetch as undiciFetch,
-  Headers as undiciHeaders,
-  Response as undiciResponse
-} from 'undici';
 import './index';

 FetchProvider.initialize(


Keeping the FetchProvider because it's used in by auth's testing framework.

DellaBitta · 2024-09-16T18:29:28Z

packages/firestore/src/platform/browser_lite/fetch_connection.ts

-    databaseInfo: DatabaseInfo,
-    private readonly fetchImpl: typeof fetch
-  ) {
-    super(databaseInfo);


This consructor is removed because it would now have the same signature as RestConnection's constructor.

packages/firestore/src/platform/node_lite/connection.ts

packages/functions/src/index.node.ts

hsubox76

Thanks, looks very thorough! Just a few questions.

hsubox76 · 2024-09-16T18:14:58Z

packages/auth/src/platform_node/index.ts

-  undiciHeaders as unknown as typeof Headers,
-  undiciResponse as unknown as typeof Response
+  fetch as unknown as typeof fetch,
+  Headers as unknown as typeof Headers,


Do we still have to do the casting or can it infer that it's a typeof, well, what it is?

hsubox76 · 2024-09-16T18:20:48Z

packages/functions/src/index.node.ts


 export * from './api';

 // eslint-disable-next-line @typescript-eslint/no-explicit-any
-registerFunctions(undiciFetch as any, 'node');
+registerFunctions('node');


Hm, I don't think we actually need a separate functions Node bundle anymore. Maybe that can be a separate PR though. The only thing different is that it labels the bundle "node" for platform logging, which is pointless if it's the same bundle. I guess it tells us how many node users are using functions. Also it doesn't export the types from public-types which is probably a mistake.

I'll add the export.

We spoke offline about removing the separate node bundle, will be done in a different PR.

packages/rules-unit-testing/test/util.test.ts

packages/storage/test/node/connection.test.ts

hsubox76 · 2024-09-16T18:33:17Z

scripts/emulator-testing/emulators/emulator.ts

                }
-                resolve();
+                const reader = resp.body?.getReader();
+                reader?.read().then(function readChunk({ done, value }): any {


Is there a chance of this hanging if there's no reader or no body? Do we have to call a resolve() or reject() or downloadFailed() or something at the end as a failsafe?

Yes, thank you! Updated the code.

NhienLam

Auth changes LGTM

NhienLam · 2024-09-19T17:26:42Z

packages/auth-compat/index.node.ts

-  undiciFetch as unknown as typeof fetch,
-  undiciHeaders as unknown as typeof Headers,
-  undiciResponse as unknown as typeof Response
+  fetch as unknown as typeof fetch,


As Christina pointed out in the other comment, we also don't need casting here, correct?

Removed node-fetch from rules-unit-testing

4bdab6f

DellaBitta added 20 commits September 11, 2024 16:24

Draft emulator impl not quite working.

45723bb

Wrap the emulator download in a promise

5ee8eb7

Update yarn.lock

84f0770

emulator.ts reject/resolve fix. formatting.

afea52d

Update emaultor.ts with chmod operation.

79753b2

emulator.ts remove setBinaryPath & add comments.

ba32125

Remove undici from messaging testing

6fdd758

Remove undici from auth source and package.json

0601594

auth format

2c4a46e

repo-scripts

3b93ffe

Auth: remove custom webpack step for undici

97eb7a3

Remove undici from firestore

9c010b2

Lint fix.

69d789c

Remove fetch from functions

c8c64e7

fix build

b16903b

Fixed build?

0c05f70

format

5077ae3

Remove undici from storage

7a6691b

Remove undici from changelog generator

033c4dc

Fix storage test for node

9aa1f75

DellaBitta changed the title ~~WIP V11 release removal of node-fetch and undici dependencies~~ V11 release removal of node-fetch and undici dependencies Sep 13, 2024

DellaBitta marked this pull request as ready for review September 13, 2024 20:55

DellaBitta requested review from avolkovi, sam-gc, yuchenshi and a team as code owners September 13, 2024 20:55

DellaBitta requested review from lisajian, Xiaoshouzi-gh, zwu52, maneesht, tonyjhuang and a team as code owners September 13, 2024 20:55

DellaBitta commented Sep 16, 2024

View reviewed changes

packages/firestore/src/platform/node_lite/connection.ts Outdated Show resolved Hide resolved

DellaBitta commented Sep 16, 2024

View reviewed changes

packages/functions/src/index.node.ts Outdated Show resolved Hide resolved

hsubox76 reviewed Sep 16, 2024

View reviewed changes

DellaBitta added 4 commits September 16, 2024 14:51

Remove no longer required eslint-disable comments.

f35d2a0

Functions export public-types

1e25ff2

Auth - remove superfluous casting.

7acb14e

Fix hanging promise in emulator download code

498bc7b

DellaBitta requested a review from hsubox76 September 19, 2024 15:57

hsubox76 approved these changes Sep 19, 2024

View reviewed changes

NhienLam requested changes Sep 19, 2024

View reviewed changes

NhienLam approved these changes Sep 19, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

V11 release removal of node-fetch and undici dependencies #8492

V11 release removal of node-fetch and undici dependencies #8492

DellaBitta commented Sep 10, 2024 •

edited

Loading

changeset-bot bot commented Sep 10, 2024 •

edited

Loading

google-oss-bot commented Sep 10, 2024 •

edited

Loading

`@firebase/auth`

`@firebase/auth-compat`

`@firebase/auth/internal`

`@firebase/firestore-lite`

`@firebase/functions`

`@firebase/rules-unit-testing`

`@firebase/storage`

`bundle`

`firebase`

google-oss-bot commented Sep 10, 2024 •

edited

Loading

`@firebase/functions`

`connectFunctionsEmulator`

`getFunctions`

`httpsCallable`

`httpsCallableFromURL`

DellaBitta Sep 16, 2024 •

edited

Loading

DellaBitta Sep 16, 2024 •

edited

Loading

hsubox76 left a comment

hsubox76 Sep 16, 2024

DellaBitta Sep 19, 2024

hsubox76 Sep 16, 2024

DellaBitta Sep 16, 2024

DellaBitta Sep 19, 2024

hsubox76 Sep 16, 2024

DellaBitta Sep 19, 2024

NhienLam left a comment

NhienLam Sep 19, 2024

V11 release removal of node-fetch and undici dependencies #8492

Are you sure you want to change the base?

V11 release removal of node-fetch and undici dependencies #8492

Conversation

DellaBitta commented Sep 10, 2024 • edited Loading

Discussion

Testing

API Changes

changeset-bot bot commented Sep 10, 2024 • edited Loading

⚠️ No Changeset found

google-oss-bot commented Sep 10, 2024 • edited Loading

Size Report 1

Affected Products

@firebase/auth

@firebase/auth-compat

@firebase/auth/internal

@firebase/firestore-lite

@firebase/functions

@firebase/rules-unit-testing

@firebase/storage

bundle

firebase

Test Logs

google-oss-bot commented Sep 10, 2024 • edited Loading

Size Analysis Report 1

Affected Products

@firebase/functions

connectFunctionsEmulator

getFunctions

httpsCallable

httpsCallableFromURL

Test Logs

DellaBitta Sep 16, 2024 • edited Loading

Choose a reason for hiding this comment

DellaBitta Sep 16, 2024 • edited Loading

Choose a reason for hiding this comment

hsubox76 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

NhienLam left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DellaBitta commented Sep 10, 2024 •

edited

Loading

changeset-bot bot commented Sep 10, 2024 •

edited

Loading

google-oss-bot commented Sep 10, 2024 •

edited

Loading

Size Report ¹

`@firebase/auth`

`@firebase/auth-compat`

`@firebase/auth/internal`

`@firebase/firestore-lite`

`@firebase/functions`

`@firebase/rules-unit-testing`

`@firebase/storage`

`bundle`

`firebase`

google-oss-bot commented Sep 10, 2024 •

edited

Loading

Size Analysis Report ¹

`@firebase/functions`

`connectFunctionsEmulator`

`getFunctions`

`httpsCallable`

`httpsCallableFromURL`

DellaBitta Sep 16, 2024 •

edited

Loading

DellaBitta Sep 16, 2024 •

edited

Loading