Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw error if mock response file not found #8739

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dlarocque
Copy link
Contributor

If we call getMockResponse with a filename that doesn't exist, we'll get some confusing error like not being able to read a property from undefined. It'd be better if we just threw an error if the mock response file doesn't exist.

@dlarocque dlarocque requested a review from hsubox76 January 29, 2025 18:53
@dlarocque dlarocque requested a review from a team as a code owner January 29, 2025 18:53
Copy link

changeset-bot bot commented Jan 29, 2025

⚠️ No Changeset found

Latest commit: c68a16d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dlarocque dlarocque force-pushed the dl/mock-lookup-error branch from ed19e79 to c68a16d Compare January 29, 2025 18:56
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 29, 2025

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 29, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants