Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(go): Added media download middleware (enabled for Google GenAI) #2402

Merged
merged 9 commits into from
Mar 24, 2025

Conversation

sahdev77
Copy link
Contributor

@sahdev77 sahdev77 commented Mar 20, 2025

Addition of downloadRequestMedia middleware to download the media as per the url in request for the model which supporting the media.
Resolving : #1928

Checklist (if applicable):

@github-actions github-actions bot added the go label Mar 20, 2025
@sahdev77 sahdev77 requested a review from apascal07 March 20, 2025 15:00
@sahdev77 sahdev77 marked this pull request as ready for review March 20, 2025 15:00
Copy link
Collaborator

@apascal07 apascal07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation and tests look good but could you please write or modify a sample in go/samples with a prompt that does inject a media URL?

@sahdev77 sahdev77 requested a review from apascal07 March 23, 2025 15:14
@apascal07 apascal07 changed the title feat(go):Handling of media download as per the url in the request feat(go): Added media download middleware (enabled for Google GenAI) Mar 24, 2025
@apascal07 apascal07 enabled auto-merge (squash) March 24, 2025 20:44
@apascal07 apascal07 merged commit 862f2e5 into main Mar 24, 2025
12 checks passed
@apascal07 apascal07 deleted the sahdev/multimodal-support branch March 24, 2025 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants