Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update devctr to 24.04 #4784

Merged
merged 13 commits into from
Oct 8, 2024
Merged

Update devctr to 24.04 #4784

merged 13 commits into from
Oct 8, 2024

Conversation

pb8o
Copy link
Contributor

@pb8o pb8o commented Sep 6, 2024 •
edited
Loading

Changes

  • Update devctr to Ubuntu 24.04
  • Refresh Python dependencies
  • Adapt tests to match the new userspace, particularly the new iperf3 version
  • Make devctr smaller

Reason

  • Keep up to date with the latest Ubuntu LTS and benefit from the updating tooling.
    In addition also

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • If a specific issue led to this PR, this PR closes the issue.
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this
    PR.
  • API changes follow the Runbook for Firecracker API changes.
  • User-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.
  • New TODOs link to an issue.
  • Commits meet
    contribution quality standards.
  • This functionality cannot be added in rust-vmm.

@pb8o pb8o added Priority: Low Indicates that an issue or pull request should be resolved behind issues or pull requests labelled ` Status: Awaiting author Indicates that an issue or pull request requires author action labels Sep 6, 2024
@pb8o pb8o self-assigned this Sep 6, 2024
@pb8o pb8o force-pushed the devctr-2404 branch 4 times, most recently from 5a11652 to a06fb20 Compare September 13, 2024 05:55
@codecov Codecov
Copy link

codecov bot commented Sep 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.38%. Comparing base (6e9d294) to head (d92a9e8).
Report is 12 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #4784   +/-   ##
=======================================
  Coverage   84.38%   84.38%           
=======================================
  Files         249      249           
  Lines       27494    27494           
=======================================
  Hits        23201    23201           
  Misses       4293     4293
Flag Coverage Δ
5.10-c5n.metal 84.62% <ø> (ø)
5.10-m5n.metal 84.60% <ø> (ø)
5.10-m6a.metal 83.90% <ø> (+<0.01%) ⬆️
5.10-m6g.metal 80.95% <ø> (ø)
5.10-m6i.metal 84.59% <ø> (-0.01%) ⬇️
5.10-m7g.metal 80.95% <ø> (ø)
6.1-c5n.metal 84.62% <ø> (ø)
6.1-m5n.metal 84.60% <ø> (ø)
6.1-m6a.metal 83.90% <ø> (+<0.01%) ⬆️
6.1-m6g.metal 80.95% <ø> (ø)
6.1-m6i.metal 84.60% <ø> (ø)
6.1-m7g.metal 80.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pb8o pb8o force-pushed the devctr-2404 branch 6 times, most recently from b0a29c2 to a1edc07 Compare September 18, 2024 08:53
@pb8o pb8o added Status: Awaiting review Indicates that a pull request is ready to be reviewed and removed Status: Awaiting author Indicates that an issue or pull request requires author action labels Sep 18, 2024
@pb8o pb8o marked this pull request as ready for review September 18, 2024 10:40
roypat
roypat previously approved these changes Sep 23, 2024
View reviewed changes
roypat
roypat previously approved these changes Oct 8, 2024
View reviewed changes
@roypat roypat mentioned this pull request Oct 8, 2024
Closed
9 tasks
@pb8o
chore(tests): simplify blockdev output checking
d9dc2c4 
It doesn't end up much shorter but at least it is more readable.

Signed-off-by: Pablo Barbáchano <[email protected]>
@pb8o
tests: drop pandas dependency
70f1ad4 
Rewrite the only test that needs pandas.

pandas is a heavy dependency that weighs in around 50MB. It also
recently started printing a warning that in the future it will require
pyarrow, which is another 40 MB.

Pandas is great, however our usage of it is minimal.

Size of devctr does not change much, but we avoid the warning, and not
having to deal with pyarrow in the future.

Example output:
```
MSR removed 0x13 before=0x0
MSR changed 0x179 before=0x20ffff after=0x20
MSR added 0x17 after=0x0
MSR added 0x11 after=0x25ba008
```

Signed-off-by: Pablo Barbáchano <[email protected]>
@pb8o
tests: capture stdout in cpu_template tests
15c542c 
Capture stdout in those tests. There is no reason why we should run
those tests differently than the others.

Also add worksteal option to xdist.

Signed-off-by: Pablo Barbáchano <[email protected]>
@pb8o
devctr: install Rust minimal profile
4622fce 
This was reverted in 157b739, but since
then we have added more Rust toolchains, so it adds up. Removing reduces
the image size quite a bit:

Uncompressed: 4.57GiB -> 3.31 GiB (-28%)
Compressed: 1213MiB -> 1058MiB (-13%)

Signed-off-by: Pablo Barbáchano <[email protected]>
@pb8o
devctr: drop dmidecode dependency
89ad60d 
This was partially done in c839707. We
can also drop it from the dependency list.

Fixes: c839707

Signed-off-by: Pablo Barbáchano <[email protected]>
@pb8o
devctr: add squashfs-tools dependency
0f373a7 
This is to be able to manipulate squashfs images during test runs.

Signed-off-by: Pablo Barbáchano <[email protected]>
@pb8o
chore(devctr): update devctr to Ubuntu 24.04
397d782 
Notably, Python and poetry required some changes to keep working the way
it was, as installing Python modules via pip outside a venv is getting
more and more difficult.

Raised the versions of Python dependencies, and updated some pinned
versions.

Signed-off-by: Pablo Barbáchano <[email protected]>
pb8o and others added 5 commits October 8, 2024 17:46
@pb8o
tests: remove spurious assignments
09b2949 
Remove some assignments without purpose.

Signed-off-by: Pablo Barbáchano <[email protected]>
@pb8o
tests: fix new pylint issues
8bd7dc9 
New version of Pylint complains about a few
`possibly-used-before-assignment`.

Signed-off-by: Pablo Barbáchano <[email protected]>
@pb8o
tests: send more data during rate_limit test to help iperf3
676eecc 
iperf3 3.16 needs to send more data to reliably detect the throughtput.

Signed-off-by: Pablo Barbáchano <[email protected]>
@roypat @pb8o
ci: enable running kani on ARM
5138c4f 
Kani supports verification on ARM since version 0.37.0 [1], so enable it
in our CI.

[1]: https://github.com/model-checking/kani/blob/main/CHANGELOG.md#0370

Signed-off-by: Patrick Roy <[email protected]>
Signed-off-by: Pablo Barbáchano <[email protected]>
@pb8o
ci: use new devctr
f6776ed 
Use the new devctr from latest changes

Signed-off-by: Pablo Barbáchano <[email protected]>
@roypat roypat merged commit f078059 into firecracker-microvm:main Oct 8, 2024
6 of 7 checks passed
@pb8o pb8o deleted the devctr-2404 branch October 8, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roypat roypat roypat approved these changes

@kalyazin kalyazin kalyazin approved these changes

Assignees

@pb8o pb8o

Labels
Priority: Low Indicates that an issue or pull request should be resolved behind issues or pull requests labelled ` Status: Awaiting review Indicates that a pull request is ready to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pb8o @kalyazin @roypat