Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add developer docs #3097

Merged
merged 27 commits into from
Aug 21, 2023
Merged

Add developer docs #3097

merged 27 commits into from
Aug 21, 2023

Conversation

veracioux
Copy link
Contributor

@veracioux veracioux commented Feb 12, 2023

Adds developer docs, including documentation generated from code comments using doxygen.

The documentation itself is not complete, but please do read it if you find the time and make suggestions what can be improved or added.

@mmahmoudian Especially read the 'Maintaining the documentation' section so you know how the documentation is deployed and maintained.

The docs are live here: https://flameshot.org/docs/dev

@mmahmoudian
Copy link
Member

I finally had some time to go through it. I just have one comment. Considering that the DOC.md is in the /docs/, doesn't it pollute the /docs/ folder? My point is that doesn't it be more clean and clear to move all these files under a dedicated folder (e.g /docs/dev-docs/ or something like that) to have all the files related to this developer documentations contained within the same folder?

@veracioux
Copy link
Contributor Author

@mmahmoudian Ah yes. I used this file as a temporary file where I would write documentation brainstorms. I accidentally committed it - and I will remove it now. (There are still some things from that file that need to be added to the proper documentation, but I'll do that another time).

@veracioux veracioux merged commit a2f036b into master Aug 21, 2023
14 of 24 checks passed
panpuchkov pushed a commit to namecheap/flameshot that referenced this pull request Dec 22, 2023
* Create developer docs

* Remove mike dependency

* Update docs

* Make docs/dev self-contained

* Add incomplete deploy-dev-docs workflow

* Fix typo

* Add workflow file to path:

* Add doxygen as dependency

* Add remaining deploy steps

* Add working-directory

* Fix working-directory error

* Add missing Makefile

* Change flameshot website repo url

* Change working-directory for safety step

* Add git credentials

* Change push credentials

* Use different token secret

* Remove checkpoints

* Add separate branch developer-docs

* Add || true

* Update docs

* Update the 'Maintaining the documentation' docs

* Fix error in deploy-dev-docs workflow

* Remove accidentally committed file DOC.md

* Update PAT expiry date

* Rename developer-docs branch to dev-docs-staging

(cherry picked from commit a2f036b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants