Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add support for Ubuntu 24.04 #3678

Merged
merged 3 commits into from
Aug 2, 2024
Merged

Conversation

rasa
Copy link
Contributor

@rasa rasa commented Jul 26, 2024

Dependent on flameshot-org/flameshot-dockerfiles#3

flameshot-org/flameshot-dockerfiles#3 has been merged, so this PR is ready to be merged too.

Fixes wimpysworld/deb-get#1144

@rasa rasa marked this pull request as draft July 29, 2024 16:39
@rasa rasa marked this pull request as ready for review July 29, 2024 17:28
@mmahmoudian mmahmoudian requested a review from holazt July 31, 2024 05:19
@mmahmoudian
Copy link
Member

@holazt do you approve this change as well?

@holazt
Copy link
Member

holazt commented Jul 31, 2024

this depends on flameshot-org/packpack#6, after it is merged, this can be merged. I have moved container images to quay from docker hub, because of docker hub pull rate limit.

@mmahmoudian
Copy link
Member

mmahmoudian commented Aug 1, 2024

@holazt I believe you have the permissions to merge. Please proceed as you wish, or let me know what I can do to help

@holazt
Copy link
Member

holazt commented Aug 2, 2024

@holazt I believe you have the permissions to merge. Please proceed as you wish, or let me know what I can do to help

@mmahmoudian Sorry, I have no permission to merge this PR. Besides, Could you help to merge this PR flameshot-org/packpack#7 too?

@holazt
Copy link
Member

holazt commented Aug 2, 2024

The building https://github.com/flameshot-org/flameshot/actions/runs/10150062277/job/28066335693?pr=3678 for opensuse leap 15.6 is failed, I think it's better to separate RPM spec file /packaging/rpm/flameshot.spec into two files, one is for fedora/rehl, another is for opensuse leap, I'll raise a new PR which will cover this PR features and fix what I mentioned issue.

@mmahmoudian mmahmoudian merged commit fd3772e into flameshot-org:master Aug 2, 2024
26 of 27 checks passed
@mmahmoudian
Copy link
Member

@rasa thanks for the PR and patience

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flameshot fails on Ubuntu 24.04
3 participants