CI - Fix Building(CMake) on Windows 2019 #3857
Open
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`jurplel/install-qt-action` provides a fix to Windows 2019 runners in commit `fc214ccc2dadadaebf48e8e5ed6ff4297dfbb732`, which is in `v4`. This fix will prevent our CI runs from failing, as they attempt to run with python 3.13 and that causes issues.
Remove QEMU dummy package installation from Linux-pack.yml (flameshot-org#3851)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: I don't want CI builds to fail (see #3851). This PR addresses the Windows 2019 Building(CMake) failures.
Problem analysis: Windows 2019 Building(CMake) runs are failing for us: https://github.com/flameshot-org/flameshot/actions/runs/13554611383/job/37886033174
The failures occur in the QT Install step:
flameshot/.github/workflows/build_cmake.yml
Lines 109 to 114 in aad3a5e
I spent some time looking into it, and it looks like
jurplel/install-qt-actionis was also having issues with python version3.13. See this commit, which limits their python versions to 3.12 now: jurplel/install-qt-action@fc214ccProposed solution:
Going from
jurplel/install-qt-action@v2tojurplel/install-qt-action@v4should fix the issue (as their commit was made tov4).My tests:
This change seems to make the build pass: https://github.com/volovikariel/flameshot/actions/runs/13568251686/job/37926340193?pr=7