Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dependencies on LLVM utilities (FileCheck) for running flang tests #1102

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add dependencies on LLVM utilities (FileCheck) for running flang tests #1102

wants to merge 1 commit into from

Conversation

joker-eph
Copy link

Without this, ninja check-flang fails with:

llvm-project/llvm/utils/lit/lit/llvm/subst.py:134: fatal: Did not find FileCheck in...

@joker-eph
Add dependencies on LLVM utilities (FileCheck) for running flang tests
c2bcb5f 
Without this, `ninja check-flang` fails with:

llvm-project/llvm/utils/lit/lit/llvm/subst.py:134: fatal: Did not find FileCheck in...
DavidTruby
DavidTruby approved these changes Apr 8, 2020
View reviewed changes
Copy link
Collaborator

@DavidTruby DavidTruby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works here, not sure why it worked for me without this before.

@joker-eph
Copy link
Author

It works if you have a prebuilt LLVM or if you run ninja check and not ninja check-flang specifically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidTruby DavidTruby DavidTruby approved these changes

@sscalpone sscalpone Awaiting requested review from sscalpone

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joker-eph @DavidTruby