fix: export metrics for checks in kubernetes resources #2455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yashmehrotra
force-pushed
the
fix-export-k8s-rc
branch
from
9e42aac to
ed2e5c4
Compare
yashmehrotra
commented
Feb 24, 2025
checks/runchecks.go
Outdated
| // Exec runs the actions specified and returns the results, without exporting any metrics | ||
| func Exec(ctx *context.Context) ([]*pkg.CheckResult, error) { | ||
| // Exec runs the actions specified and returns the results, without saving artifacts | ||
| func Exec(ctx *context.Context, exportMetrics bool) ([]*pkg.CheckResult, error) { |
There was a problem hiding this comment.
@moshloop @adityathebe
This function is used by topology run and kubernetes resource check, was the reason to not export metrics only for topology run to not export metrics if the checks had it defined ?
There was a problem hiding this comment.
I think in both cases if a custom metric is defined it should be exported - but we shouldn't export the standard check metrics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2445