fix(ui+electron): OAuth2 > disableSSLVerification flag is not respect…

…ed by oauth 2 requests (fixes #283)
flawiddsouza · Oct 15, 2024 · 8d16787 · 8d16787
1 parent d8bd377
commit 8d16787
Show file tree

Hide file tree

Showing 7 changed files with 51 additions and 28 deletions.
diff --git a/packages/electron/package-lock.json b/packages/electron/package-lock.json
diff --git a/packages/electron/package.json b/packages/electron/package.json
@@ -46,11 +46,11 @@
         "electron-context-menu": "^3.6.1",
         "electron-log": "^5.1.2",
         "electron-squirrel-startup": "^1.0.0",
-        "open": "^10.1.0",
-        "undici": "^6.19.2",
-        "update-electron-app": "^2.0.1",
         "jsonfile": "^4.0.0",
-        "mkdirp": "^0.5.1"
+        "mkdirp": "^0.5.1",
+        "open": "^10.1.0",
+        "undici": "^6.20.1",
+        "update-electron-app": "^2.0.1"
     },
     "config": {
         "forge": "./forge.config.js"

diff --git a/packages/ui/.eslintrc.js → packages/ui/.eslintrc.cjs b/packages/ui/.eslintrc.js → packages/ui/.eslintrc.cjs
diff --git a/packages/ui/src/components/FolderPanel.vue b/packages/ui/src/components/FolderPanel.vue
@@ -5,7 +5,10 @@
             <div class="request-panel-tabs-context">
                 <div style="font-weight: 500; margin-bottom: var(--label-margin-bottom)">Headers</div>
                 <div>
-                    <RequestPanelHeaders :collection-item="collectionItem" :collection-item-environment-resolved="envVariables"></RequestPanelHeaders>
+                    <RequestPanelHeaders
+                        :collection-item="collectionItem"
+                        :collection-item-environment-resolved="envVariables"
+                    />
                 </div>
                 <InfoTip />
             </div>
@@ -15,7 +18,11 @@
             <div class="request-panel-tabs-context">
                 <div style="font-weight: 500; margin-bottom: var(--label-margin-bottom)">Auth</div>
                 <div>
-                    <RequestPanelAuth :collection-item="collectionItem" :collection-item-environment-resolved="envVariables"></RequestPanelAuth>
+                    <RequestPanelAuth
+                        :collection-item="collectionItem"
+                        :collection-item-environment-resolved="envVariables"
+                        :flags="flags"
+                    />
                 </div>
                 <InfoTip />
             </div>
@@ -56,6 +63,11 @@ export default {
             envVariables: {},
         }
     },
+    computed: {
+        flags() {
+            return this.$store.state.flags
+        },
+    },
     watch: {
         collectionItem: {
             immediate: true,

diff --git a/packages/ui/src/components/RequestPanel.vue b/packages/ui/src/components/RequestPanel.vue
@@ -360,6 +360,7 @@
                 <RequestPanelAuth
                     :collection-item="activeTab"
                     :collection-item-environment-resolved="collectionItemEnvironmentResolved"
+                    :flags="flags"
                     @tagClick="onTagClick"
                 />
             </template>
@@ -651,6 +652,9 @@ export default {
         collectionItemEnvironmentResolved() {
             return this.$store.state.tabEnvironmentResolved[this.activeTab._id] ?? {}
         },
+        flags() {
+            return this.$store.state.flags
+        },
         scriptPlugin() {
             if(this.activeTab === null) {
                 return undefined

diff --git a/packages/ui/src/components/RequestPanelAuth.vue b/packages/ui/src/components/RequestPanelAuth.vue
@@ -276,7 +276,7 @@
 <script setup lang="ts">
 import { computed, PropType, ref } from 'vue'
 import CodeMirrorSingleLine from './CodeMirrorSingleLine.vue'
-import { CollectionItem } from '@/global'
+import { CollectionItem, Flags } from '@/global'
 import ContextMenu from '@/components/ContextMenu.vue'
 import constants from '@/constants'
 import { fetchWrapper, substituteEnvironmentVariables } from '@/helpers'
@@ -293,7 +293,11 @@ const props = defineProps({
     collectionItemEnvironmentResolved: {
         type: Object as PropType<any>,
         required: true
-    }
+    },
+    flags: {
+        type: Object as PropType<Flags>,
+        required: true
+    },
 })
 
 const emit = defineEmits(['tagClick'])
@@ -443,8 +447,8 @@ async function requestOAuthToken() {
             }
 
             const response = await fetchWrapper(accessTokenUrl, 'POST', headers, bodyData.toString(), abortController.signal, {
-                electronSwitchToChromiumFetch: false,
-                disableSSLVerification: false,
+                electronSwitchToChromiumFetch: props.flags.electronSwitchToChromiumFetch,
+                disableSSLVerification: props.flags.disableSSLVerification,
             })
 
             if(response.status !== 200) {
@@ -493,8 +497,8 @@ async function refreshOAuthToken() {
                 }
 
                 const response = await fetchWrapper(accessTokenUrl, 'POST', headers, bodyData.toString(), abortController.signal, {
-                    electronSwitchToChromiumFetch: false,
-                    disableSSLVerification: false,
+                    electronSwitchToChromiumFetch: props.flags.electronSwitchToChromiumFetch,
+                    disableSSLVerification: props.flags.disableSSLVerification,
                 })
 
                 if(response.status !== 200) {

diff --git a/packages/ui/src/global.d.ts b/packages/ui/src/global.d.ts
@@ -110,6 +110,16 @@ export interface RequestFinalResponse {
     name?: string
 }
 
+export interface Flags {
+    hideBrowserRelatedResponsePanelErrors: boolean
+    browserExtensionEnabled: boolean
+    isBrowser: boolean
+    isWebStandalone: boolean
+    isElectron: boolean
+    disableSSLVerification: boolean
+    electronSwitchToChromiumFetch: boolean
+}
+
 export interface State {
     consoleLogs: string[]
     collection: CollectionItem[]
@@ -139,15 +149,7 @@ export interface State {
     theme: string
     githubStarCount: string
     sidebarItemTemporaryName: { [key: string]: string }
-    flags: {
-        hideBrowserRelatedResponsePanelErrors: boolean
-        browserExtensionEnabled: boolean
-        isBrowser: boolean
-        isWebStandalone: boolean
-        isElectron: boolean
-        disableSSLVerification: boolean
-        electronSwitchToChromiumFetch: boolean
-    }
+    flags: Flags
     openContextMenuElement: HTMLElement | null
     sockets: { [key: string]: WebSocket | null }
     tabEnvironmentResolved: any