Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): active tab style #279

Merged
merged 4 commits into from
Oct 11, 2024
Merged

fix(ui): active tab style #279

merged 4 commits into from
Oct 11, 2024

Conversation

kobenguyent
Copy link
Collaborator

resolves #277

Copy link

netlify bot commented Oct 11, 2024

Deploy Preview for chimerical-kitsune-a0bfa0 ready!

Name Link
🔨 Latest commit 8990e46
🔍 Latest deploy log https://app.netlify.com/sites/chimerical-kitsune-a0bfa0/deploys/67093ad717dcf20008f9bd20
😎 Deploy Preview https://deploy-preview-279--chimerical-kitsune-a0bfa0.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@flawiddsouza
Copy link
Owner

Hey @kobenguyent, can you give me a reasoning for the new 5px top margin? I tried to like it but it just seems slightly off.

@kobenguyent
Copy link
Collaborator Author

Hey @kobenguyent, can you give me a reasoning for the new 5px top margin? I tried to like it but it just seems slightly off.

Screenshot 2024-10-11 at 16 28 35
just thinking to refer as chrome so that's why I added 5px to top margin. Still opening for what fits us better.

@flawiddsouza
Copy link
Owner

I did notice the same in chrome but our design doesn't look like chrome, so:
image
The issue I think is the line separator in between. Let's not have this margin for now. We'll have it if we update the design of the tabs to look more like chrome, which I'd love.

@kobenguyent
Copy link
Collaborator Author

I did notice the same in chrome but our design doesn't look like chrome, so: image The issue I think is the line separator in between. Let's not have this margin for now. We'll have it if we update the design of the tabs to look more like chrome, which I'd love.

oh sure, let me remove the top margin then.

@flawiddsouza flawiddsouza merged commit 25f554a into main Oct 11, 2024
6 checks passed
@flawiddsouza flawiddsouza deleted the fix-active-tab-style branch October 11, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tab active style
2 participants