Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update app-exit-confirm-dialog.py #167

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

non-npc
Copy link
Contributor

@non-npc non-npc commented Sep 12, 2024

Resolves the following deprecation errors:
window_prevent_close()
dialog()
window_destroy()

Resolves the following deprecation errors:
window_prevent_close()
dialog()
window_destroy()
@@ -34,5 +35,5 @@ def no_click(e):

page.add(Text('Try exiting this app by clicking window\'s "Close" button!'))


flet.app(target=main)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why two lines to run the app?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!, copy paste typo! eek!


def yes_click(e):
page.window_destroy()
# Use the updated method to destroy the window
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to add comments in this case.

def main(page: Page):
page.title = "MyApp"

def window_event(e):
if e.data == "close":
page.dialog = confirm_dialog
# Use the updated method to append the dialog to the overlay
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for this comment too.

@ndonkoHenri
Copy link
Collaborator

@non-npc, thanks again for your contirbutions.

While on this, could you equally update the code you work on to use import flet as ft instead of importing each Control?

@non-npc
Copy link
Contributor Author

non-npc commented Sep 12, 2024

@non-npc, thanks again for your contirbutions.

While on this, could you equally update the code you work on to use import flet as ft instead of importing each Control?

absolutely going forward I will do this.
Thank you for making a wonderful python library.

@ndonkoHenri
Copy link
Collaborator

Thank you for making a wonderful python library.

@FeodorFitsner 🫡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants