Fix bytes race #981
Merged
Fix bytes race #981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makeevrserg
force-pushed
the
fix-missing-bytes-cool
branch
from
ffa14bc to
e75e2c3
Compare
makeevrserg
commented
Oct 30, 2024
...ommonMain/kotlin/com/flipperdevices/bridge/connection/feature/rpc/impl/FRpcFeatureApiImpl.kt
Outdated
Show resolved
Hide resolved
makeevrserg
force-pushed
the
fix-missing-bytes-cool
branch
from
4e2e79b to
c90c757
Compare
…-missing-bytes-cool
# Conflicts: # CHANGELOG.md
LionZXY
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
When sending a lot of bytes to flipper, some of them may be missed. This is happening because of a bug inside new
FlipperSerialOverflowThrottlerChanges
Test plan