Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix build when metrics disabled #989

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

makeevrserg
Copy link
Collaborator

Background

Android Project can't be build with disabled metrics due to it's inject in SingleActivity #988

Changes

  • Add NoOp for AndroiMetricsApi

Test plan

  • Assemble project with disabled metrics

@makeevrserg makeevrserg requested a review from LionZXY as a code owner November 12, 2024 11:08
@LionZXY LionZXY merged commit c879b21 into flipperdevices:dev Nov 12, 2024
9 checks passed
@makeevrserg makeevrserg deleted the fix-metrics-noop branch December 2, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants