Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add subfolders count to file manager #991

Merged
merged 9 commits into from
Nov 26, 2024
Merged

add subfolders count to file manager #991

merged 9 commits into from
Nov 26, 2024

Conversation

makeevrserg
Copy link
Collaborator

@makeevrserg makeevrserg commented Nov 25, 2024 •
edited
Loading

Background

Current file manager doesn't display subitems count inside folders

Changes

  • Add subitems count
  • Add ExtendedListingItem for better scalability
  • Add visible parameter for PlaceholderConnecting so there will be animation when it's loaded

Test plan

  • Open sample app
  • Open folders and see items are loading and each after each without blocking the listing itself

@makeevrserg makeevrserg requested a review from LionZXY as a code owner November 25, 2024 13:21
@makeevrserg makeevrserg added this pull request to the merge queue Nov 26, 2024
Merged via the queue into flipperdevices:dev with commit 895a2f6 Nov 26, 2024
9 checks passed
@makeevrserg makeevrserg deleted the add-folders-items-count branch November 26, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LionZXY LionZXY LionZXY approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@makeevrserg @LionZXY