Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FlipTDI crashing on Linux when connecting to a Linux system #267

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

Jan200101
Copy link

What's new

  • fixes crash in ftdi_usb_callback_tx_immediate due to assert

I'm not entirely sure how accurate my debugging was, the debugger kept pointing at furi_thread_get_id(ftdi_usb->thread) in the traceback and looking through the short furi_thread_get_id code shows that its checking the given pointer using furi_check and apparently thats where an assert was triggering.

I haven't managed to inspect the contents of ftdi_usb because it was optimized out and a log statement didn't print anything.

Verification

  • Start FlipTDI
  • Plug into Linux system
  • verify the device is seen as an FT232H using dmesg
  • exit app

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant