-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
msi: keep fluentdopt when previous options is set #609
base: master
Are you sure you want to change the base?
Conversation
kenhys
commented
Dec 21, 2023
- It will be overridden when install path has changed.
- If fluentdopt is empty, set default value
- If install path is same, do not change it.
TODO: check behavior. |
247d09d
to
66c394a
Compare
Need to fix it.
|
66c394a
to
efa02b7
Compare
I've forgot to bundle script. |
754f0fe
to
334ced4
Compare
should fix unexpected error. |
33aff94
to
11b1b94
Compare
migration script itself works, but integrated with installer does not works as expected, |
It is strange that appended install path seems corrupted and it raise Registry::Error when accessing fluentdopt. |
11b1b94
to
939d3d6
Compare
I've created minimum installer to assess the root cause, but it is not reproduced yet. hmm. (quoting bug is out of scope)
|
Before: * always reset fluentdopt After: * If fluentdopt is empty, set default value * If fluentdopt configuration is changed from default one, keep it. Signed-off-by: Kentaro Hayashi <[email protected]>
939d3d6
to
f5986d5
Compare
Sorry I'm not check this in detail, but we should note that the service is reinstalled when updating. |