Fix/cljs update #977
Merged
Fix/cljs update #977
+13
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason the regex #":(?!.*:)" was producing a different result on the browser and in nodejs than on the jvm: ; clj: (split-address "fluree:memory://testledger") ["fluree:memory" "//testledger"] ; cljs: (split-address "fluree:memory://testledger") ["fluree" "memory://testledger"] All the documentation I could find indicates that this regex should in fact work cross-platform, but for some reason it reliably did not. I have replaced its use with an alternate implementation that safely avoids the issue.
bplatz
reviewed
Feb 24, 2025
| datetime))))) | ||
| :cljs (.getTimeZoneOffset ^js/Date (if (string? x) | ||
| (datatype/coerce (:value x) (:datatype-iri x)) | ||
| x))))) |
There was a problem hiding this comment.
I think above still has an error in it...
If x is a string?, then I don't think (:value x), etc. would work.
Should it be (map? x), or maybe (string? (:value x))?
There was a problem hiding this comment.
Good catch, it should be (string? (:value x))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A collection of cljs fixes from #915