Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flytepropeller][flyteadmin] Streaming Decks V2 #6053

Merged
merged 34 commits into from
Jan 24, 2025

add comments and better solution for backward compativle

25fea29
Select commit
Loading
Failed to load commit list.
Merged

[flytepropeller][flyteadmin] Streaming Decks V2 #6053

add comments and better solution for backward compativle
25fea29
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Dec 17, 2024 in 0s

36.97% (-0.11%) compared to ab04192

View this Pull Request on Codecov

36.97% (-0.11%) compared to ab04192

Details

Codecov Report

Attention: Patch coverage is 32.43243% with 50 lines in your changes missing coverage. Please review.

Project coverage is 36.97%. Comparing base (ab04192) to head (25fea29).
Report is 28 commits behind head on master.

Files with missing lines Patch % Lines
...lytepropeller/pkg/controller/nodes/task/handler.go 31.50% 41 Missing and 9 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6053      +/-   ##
==========================================
- Coverage   37.08%   36.97%   -0.11%     
==========================================
  Files        1318     1318              
  Lines      132284   132497     +213     
==========================================
- Hits        49062    48996      -66     
- Misses      78950    79241     +291     
+ Partials     4272     4260      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.