Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not depending on fractal-tasks-core[fractal-tasks] may introduce import errors #113

Closed
tcompa opened this issue Jul 19, 2024 · 2 comments · Fixed by #117
Closed

Not depending on fractal-tasks-core[fractal-tasks] may introduce import errors #113

tcompa opened this issue Jul 19, 2024 · 2 comments · Fixed by #117

Comments

@tcompa
Copy link
Collaborator

tcompa commented Jul 19, 2024

For your info, we have spotted the following issue related to how scMultiplex depends on fractal-tasks-core:

I think it will be fixed or mitigated on the fractal-task-core side, but I'm re-raising the issue here to let you know that you may find a ModuleNotFoundError due to this reason.

In case this becomes a blocking issue, I think that a temporary solution would be to add image_registration as a dependency for scMultiplex.

@jluethi
Copy link
Contributor

jluethi commented Jul 22, 2024

For the moment: Let's not update to the fractal-tasks-core 1.1.0 dependency (or higher) in scmultiplex until this has been resolved.

My bad for adding this to that utils module / using a task subpackage dependency in scmultiplex.

@jluethi
Copy link
Contributor

jluethi commented Aug 8, 2024

This is now fixed in fractal-tasks-core 1.2.1. The utils function can now be imported as from fractal_tasks_core.utils import create_well_acquisition_dict and no extras are required.

I'll create a PR (likely next week) for updating this dependency. It also contains the pydantic V2 switch, which shouldn't be too tricky for this repo I think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants