Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fractal tasks core dep, pre-commit cleanup & manifest update #115

Closed
wants to merge 6 commits into from

Conversation

jluethi
Copy link
Contributor

@jluethi jluethi commented Aug 12, 2024

Hey @nrepina

I made a PR here to update to the newest version of fractal-tasks-core. The core update concerns using pydanticV2 => different syntax for the fractal task function validation. Due to pre-commit, there are lots of minor changes though in the task functions. They are all just automated syntax updates, not manual changes by me.

Further additions:

  • I also added the fix for the numpy floats that should allow us to relax the numpy dependency (I kept it pinned under 2, as I'd expect that there may be additional issues there) => closes Handle np.float deprecation #104
  • Fix the import of create_well_acquisition_dict to work with new fractal-tasks-core version => closes Not depending on fractal-tasks-core[fractal-tasks] may introduce import errors #113
  • Very minor syntax fixes by running pre-commit across the task functions. That also found 2 variables that were defined and never used (see FIXME comments). Do you want to keep using pre-commit? Happy to help setting it up in your local dev environment if that's useful for you
  • I noticed that the manifest wasn't fully up-to-date. Part of it was just an unexpected ordering of entries (dunno where that came from). I now updated the manifest (makes tests pass on the fractal-tasks-core side, because we also check whether our manifest creation breaks scmultiplex manifests) & added tests to check that the manifest that's on Github is up-to-date with the source code.
  • Very minor typing update to the measurement task to ensure not providing any intensity channels to measure still works in pydanticV2 world

The PR would be ready for review from your side. Let me know if any questions come up

@jluethi jluethi requested a review from nrepina August 12, 2024 11:54
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.28%. Comparing base (12d586b) to head (e2489a8).
Report is 140 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #115      +/-   ##
==========================================
- Coverage   98.91%   98.28%   -0.64%     
==========================================
  Files          10       15       +5     
  Lines         461      698     +237     
==========================================
+ Hits          456      686     +230     
- Misses          5       12       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jluethi
Copy link
Contributor Author

jluethi commented Aug 14, 2024

New version of this available here: #117

@jluethi jluethi closed this Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not depending on fractal-tasks-core[fractal-tasks] may introduce import errors Handle np.float deprecation
2 participants