Improve feature wrapper and fractal task #61
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was anyway working on integrating the feature_wrapper function better into the Fractal task, so I also did a small refactor to address #59.
The new
get_regionprops_measurements
is simplified and calls 3 helper functions for the main measurements. In my tests, it still performs the same as before (except theC01.x_pos_weighted_pix
etc. measurement being quite different, but that was an intentional bug fix, right?Fractal testing is still ongoing, but this can already be merged now to avoid to many different branches in parallel.