Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automated testing for Fractal measurements & masked measurements #81

Merged
merged 14 commits into from
Jun 21, 2023

Conversation

jluethi
Copy link
Contributor

@jluethi jluethi commented Jun 15, 2023

I've been running into a measurement bug in Fractal and thus decided it was time to build some automated testing. Here's a draft for it.

This PR doesn't actually close my original issue (#79) yet, because I haven't yet been able to reproduce it in the tests. But I think it's valuable in any case that we'd add automated testing.

These tests here would add the following:

  1. OME-Zarr example data (tiny OME-Zarrs) with measurement tables as scMultipleX generates them at the moment
  2. Tests that run measurements on 2D & 3D, with or without morphology on this dataset and compare it with the expected measurements contained in the OME-Zarr file
  3. A github automation that should trigger these tests automatically upon pull requests & commits to main.

I'm not fully sure whether the github automation is already working it, I'm opening the PR to test it.

@jluethi
Copy link
Contributor Author

jluethi commented Jun 15, 2023

Hmm, running into a weird error now that does not occur locally. Had some issues with uploading the example data to github though, so not sure whether something could have gotten corrupted. I'll need to investigate further

@jluethi jluethi marked this pull request as draft June 15, 2023 13:32
@jluethi jluethi changed the title Add automated testing for Fractal measurements Add automated testing for Fractal measurements & masked measurements Jun 16, 2023
@jluethi
Copy link
Contributor Author

jluethi commented Jun 16, 2023

This PR now also includes support to make measurements in masked ROIs, i.e. measure all the cells within an organoid, but don't make measurements of other cells in the bounding box (but not in the organoid mask).

Also, adding it to the FMI Fractal setup now and testing whether it solves #79 . In local tests, #79 was running fine now.

@jluethi
Copy link
Contributor Author

jluethi commented Jun 16, 2023

7ca9cea closes #79

@jluethi jluethi marked this pull request as ready for review June 16, 2023 20:29
@jluethi jluethi requested a review from nrepina June 16, 2023 20:30
@jluethi
Copy link
Contributor Author

jluethi commented Jun 16, 2023

Hey @nrepina
This PR fixes the issues I originally hit, as well as adding quite extensive automated testing for the Fractal scMultipleX task to ensure that we get the same results going forward :)
From my side, it's ready to be merged (and already deployed at FMI)

@nrepina
Copy link
Collaborator

nrepina commented Jun 21, 2023

This looks great, thanks @jluethi ! Merging now and will test it next week on the scmultiplex side.

@nrepina nrepina merged commit c18bfac into main Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support masked ROI loading in Fractal task Measurement bug in 3D Fractal measurements
2 participants