-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add automated testing for Fractal measurements & masked measurements #81
Conversation
…the fractal-tasks tests)
Hmm, running into a weird error now that does not occur locally. Had some issues with uploading the example data to github though, so not sure whether something could have gotten corrupted. I'll need to investigate further |
This PR now also includes support to make measurements in masked ROIs, i.e. measure all the cells within an organoid, but don't make measurements of other cells in the bounding box (but not in the organoid mask). Also, adding it to the FMI Fractal setup now and testing whether it solves #79 . In local tests, #79 was running fine now. |
Hey @nrepina |
This looks great, thanks @jluethi ! Merging now and will test it next week on the scmultiplex side. |
I've been running into a measurement bug in Fractal and thus decided it was time to build some automated testing. Here's a draft for it.
This PR doesn't actually close my original issue (#79) yet, because I haven't yet been able to reproduce it in the tests. But I think it's valuable in any case that we'd add automated testing.
These tests here would add the following:
I'm not fully sure whether the github automation is already working it, I'm opening the PR to test it.