Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Chinese translation to v0.33.0 #323

Closed
wants to merge 2 commits into from
Closed

Conversation

BG7JAF
Copy link

@BG7JAF BG7JAF commented Feb 23, 2024

I have update the Chinese translation to v0.32.0.
Because I upload the ts file to crowdin.com to do the translation, so maybe the file's indent is not like before.

@foldynl
Copy link
Owner

foldynl commented Feb 23, 2024

Thank you. It will be a part of the next release. Unfortunately, I am not able to verify the quality of the translation provided by crowdin.com – I have to trust you to verify it before generating the PR.

@foldynl
Copy link
Owner

foldynl commented Feb 28, 2024

I have implemented #322 in the testing_0.33 branch. Could you please update your transaction against this branch? This PR is already included there, so your work won't be lost.

@BG7JAF
Copy link
Author

BG7JAF commented Feb 28, 2024

I have implemented #322 in the testing_0.33 branch. Could you please update your transaction against this branch? This PR is already included there, so your work won't be lost.

Glad to hear that. I'll update the translation and re-upload it.
73

@BG7JAF BG7JAF changed the title update Chinese translation to v0.32.0 update Chinese translation to v0.33.0 Feb 29, 2024
@foldynl
Copy link
Owner

foldynl commented Feb 29, 2024

Thanks. there are many conflicts with your previous PR (indentation problem), so I couldn't do a direct merge. Therefore I had to replace the file and it seems that the translation file is valid again. Translation file is a part of testing_0.33 branch now.

@BG7JAF BG7JAF closed this Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants