refactor: don't mutate params #1047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristiand391
approved these changes
Apr 9, 2024
shetzel
approved these changes
Apr 9, 2024
| @@ -848,26 +840,26 @@ export class AuthInfo extends AsyncOptionalCreatable<AuthInfo.Options> { | |||
| let authConfig: AuthFields; | |||
|
|
|||
| if (options) { | |||
| options = structuredClone(options); | |||
| const clonedOptions = structuredClone(options); | |||
There was a problem hiding this comment.
This one would be my biggest concern about whether the mutation was causing side effect behavior.
There was a problem hiding this comment.
ooh, good point, that could be bad.
We don't have full NUT coverage here (we're always either sfdx-url or JWT, never accessToken or web, device, etc).
I think'll I'll put this back like it was with a TODO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
fix code flagged by https://eslint.org/docs/latest/rules/no-param-reassign
some changes to messages for the es2022 error changes (namedError => sfError)
[skip-validate-pr]