fix(build-details): deep-merged into the package scaffolding results …

…so scripts arent lost
form8ion · Jun 11, 2022 · 07f343f · 07f343f
1 parent e67c44e
commit 07f343f
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/src/scaffolder/project-type/package/scaffolder-test.js b/src/scaffolder/project-type/package/scaffolder-test.js
@@ -265,6 +265,10 @@ suite('package project-type', () => {
 
   test('that the registry to publish to is defined when provided', async () => {
     const publishRegistry = any.url();
+    const dialect = jsCore.dialects.BABEL;
+    buildDetails.default
+      .withArgs({projectRoot, projectName, packageBundlers, visibility, packageName, dialect, decisions})
+      .resolves(buildDetailsResults);
 
     await scaffoldPackage({
       projectRoot,
@@ -277,7 +281,8 @@ suite('package project-type', () => {
       packageTypes,
       tests,
       publishRegistry,
-      dialect: jsCore.dialects.BABEL
+      dialect,
+      packageBundlers
     });
 
     assert.calledWith(

diff --git a/src/scaffolder/project-type/package/scaffolder.js b/src/scaffolder/project-type/package/scaffolder.js
@@ -74,7 +74,6 @@ export default async function ({
 
   return deepmerge.all([
     {
-      ...detailsForBuild,
       documentation: scaffoldPackageDocumentation({packageName, visibility, scope, packageManager}),
       eslintConfigs: [],
       nextSteps: [
@@ -84,6 +83,7 @@ export default async function ({
       scripts: {},
       badges: defineBadges(packageName, visibility)
     },
+    detailsForBuild,
     results
   ]);
 }