feat(babel-istanbul): also removed the babel-plugin when moving away …

…from nyc
form8ion · Jun 3, 2022 · d94a8a3 · d94a8a3
1 parent 2d00350
commit d94a8a3
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/src/coverage/nyc/remover-test.js b/src/coverage/nyc/remover-test.js
@@ -30,7 +30,7 @@ suite('nyc remover', () => {
     assert.calledWith(fs.rmdir, `${projectRoot}/.nyc_output`, {recursive: true, force: true});
     assert.calledWith(
       dependencyRemover.default,
-      {packageManager, dependencies: ['nyc', '@istanbuljs/nyc-config-babel']}
+      {packageManager, dependencies: ['nyc', '@istanbuljs/nyc-config-babel', 'babel-plugin-istanbul']}
     );
   });
 });
diff --git a/src/coverage/nyc/remover.js b/src/coverage/nyc/remover.js
@@ -5,6 +5,6 @@ export default async function ({projectRoot, packageManager}) {
   await Promise.all([
     fs.unlink(`${projectRoot}/.nycrc`),
     fs.rmdir(`${projectRoot}/.nyc_output`, {recursive: true, force: true}),
-    removeDependencies({packageManager, dependencies: ['nyc', '@istanbuljs/nyc-config-babel']})
+    removeDependencies({packageManager, dependencies: ['nyc', '@istanbuljs/nyc-config-babel', 'babel-plugin-istanbul']})
   ]);
 }
diff --git a/test/integration/features/step_definitions/coverage-steps.js b/test/integration/features/step_definitions/coverage-steps.js
@@ -21,7 +21,11 @@ Given('existing c8 config is present', async function () {
 Then('nyc is not configured for code coverage', async function () {
   assert.isFalse(await fileExists(`${process.cwd()}/.nycrc`));
   assert.isFalse(await directoryExists(`${process.cwd()}/.nyc_output`));
-  assertDependenciesWereRemoved(this.execa, this.packageManager, ['nyc', '@istanbuljs/nyc-config-babel']);
+  assertDependenciesWereRemoved(
+    this.execa,
+    this.packageManager,
+    ['nyc', '@istanbuljs/nyc-config-babel', 'babel-plugin-istanbul']
+  );
 });
 
 Then('c8 is configured for code coverage', async function () {