fix: label for attribute should be only for form elements

formwerkjs · Feb 22, 2025 · b2b5297 · b2b5297
1 parent 71873de
commit b2b5297
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/.changeset/five-planes-teach.md b/.changeset/five-planes-teach.md
@@ -0,0 +1,5 @@
+---
+'@formwerk/core': patch
+---
+
+fix: label "for" attribute should be only for form elements
diff --git a/packages/core/src/a11y/useLabel.ts b/packages/core/src/a11y/useLabel.ts
@@ -17,7 +17,7 @@ export function useLabel(props: LabelProps) {
     return {
       ref: refCapture,
       id: `${toValue(props.for)}-l`,
-      for: isLabelElement(labelRef.value) ? toValue(props.for) : undefined,
+      for: isLabelElement(labelRef.value) && isInputElement(toValue(props.targetRef)) ? toValue(props.for) : undefined,
       onClick: props.handleClick || undefined,
     } as AriaLabelProps;
   });