feat: remove arrow left/right behavior which is not standard

formwerkjs · Aug 30, 2024 · f4f8307 · f4f8307
1 parent 17e1ac7
commit f4f8307
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 36 deletions.
diff --git a/packages/core/src/useSelect/useSelect.spec.ts b/packages/core/src/useSelect/useSelect.spec.ts
@@ -376,17 +376,6 @@ describe('keyboard features for a single select', () => {
     await flush();
     expect(screen.getAllByRole('option')[1]).toHaveAttribute('aria-selected', 'false');
   });
-
-  test('Pressing ArrowRight and ArrowLeft should toggle the selected option without opening the list', async () => {
-    await renderSelect();
-
-    await fireEvent.keyDown(getSelect(), { code: 'ArrowRight' });
-    expect(screen.getAllByRole('option')[0]).toHaveAttribute('aria-selected', 'true');
-    await fireEvent.keyDown(getSelect(), { code: 'ArrowRight' });
-    expect(screen.getAllByRole('option')[1]).toHaveAttribute('aria-selected', 'true');
-    await fireEvent.keyDown(getSelect(), { code: 'ArrowLeft' });
-    expect(screen.getAllByRole('option')[0]).toHaveAttribute('aria-selected', 'true');
-  });
 });
 
 describe('keyboard features for a multi select', () => {

diff --git a/packages/core/src/useSelect/useSelect.ts b/packages/core/src/useSelect/useSelect.ts
@@ -91,10 +91,6 @@ export function useSelect<TOption, TValue = TOption>(
     errorMessage,
   });
 
-  function getSelectedIdx() {
-    return options.value.findIndex(opt => opt.isSelected());
-  }
-
   function isSingle() {
     const isMultiple = toValue(props.multiple);
 
@@ -190,13 +186,6 @@ export function useSelect<TOption, TValue = TOption>(
 
   provide(SelectionContextKey, selectionCtx);
 
-  function setSelectedByRelativeIdx(relativeIdx: number) {
-    // Clamps selection between 0 and the array length
-    const nextIdx = Math.max(0, Math.min(options.value.length - 1, getSelectedIdx() + relativeIdx));
-    const option = options.value[nextIdx];
-    selectionCtx.toggleValue(option.getValue());
-  }
-
   const handlers = {
     onClick() {
       isOpen.value = !isOpen.value;
@@ -207,20 +196,6 @@ export function useSelect<TOption, TValue = TOption>(
         isOpen.value = true;
         return;
       }
-
-      if (!selectionCtx.isMultiple() && !isOpen.value) {
-        if (e.code === 'ArrowLeft') {
-          e.preventDefault();
-          setSelectedByRelativeIdx(-1);
-          return;
-        }
-
-        if (e.code === 'ArrowRight') {
-          e.preventDefault();
-          setSelectedByRelativeIdx(1);
-          return;
-        }
-      }
     },
   };